Add padding to Sharedaddy buttons on mobile#5888
Add padding to Sharedaddy buttons on mobile#5888dereksmart merged 1 commit intoAutomattic:masterfrom
Conversation
georgestephanis
left a comment
There was a problem hiding this comment.
Would this maybe make more sense to do if we detect an interface that supports touch events? That is, do it in Javascript and add a body class like "jp-sharing-input-touch" that would increase the space between?
I worry as this patch wouldn't do anything to help touchscreen Windows laptops or tablets that have widths larger than 767px.
Also, 767 pixels feels a bit arbitrary? Is the idea just to assume anything less than 768px is a touchscreen? cc: @MichaelArestad for dimensions / best practices on that front.
|
@georgestephanis Yeah. They're pretty arbitrary in general. iPads used to only be |
7756ab0 to
d9bc171
Compare
|
@stoyan0v Thanks for the update -- does this change appease Google's scanner? My only hesitancy is whether their scanner is just scanning for general ui, or if it picks up on this sort of adaptive change. |
modules/sharedaddy/sharing.js
Outdated
There was a problem hiding this comment.
It'd probably be a bit more performant to use $( document.body ) here, instead of passing 'body' through the selector engine.
https://developer.mozilla.org/en-US/docs/Web/API/Document/body
https://www.sitepoint.com/jquery-body-on-document-on/
|
Hi @georgestephanis, it may sounds as stupid question, but what does "Google's scanner" means? |
|
@stoyan0v I meant the Google Webmaster Tools thing that the initial PR referenced. |
georgestephanis
left a comment
There was a problem hiding this comment.
With the changes, it looks good to me.
It'd be nice to get a question answered before merging, just to confirm it behaves as expected in Google Webmaster Tools.
19fa42e to
a83c868
Compare
|
Thanks for clarification @georgestephanis. I've replaced the body selector as you requested, but I am not sure that the modifications change the test result. I always receive a message that the site is mobile friendly, even without the patch. Maybe there is some cache, or the padding is not such problem, when the theme is mobile friendly ( I am testing with Twentyseventeen ). |
|
Looks reasonable and fixes the problem at hand. Merging as George already approved. |
* Changelog: update stable tag and move changelog to changelog.txt Also remove old releases from readme.txt to keep the changelog tab short. * Changelog: add #5883 Also update the filter's docblock to match new version. * Changelog: add #5938 * Changelog: add #6298 * Changelog: add #3405 * Changelog: add #5941 * Changelog: add #6239 * Changelog: add #6281 * Changelog: add #6303 * Changelog: add #6018 * Changelog: add #6300 * Changelog: add #6296 * Changelog: add #6130 * Changelog: add #6292 * Readme: remove extra "on". * Changelog: add #6307 * Changelog: add #3297 * Changelog: add #6275 * Changelog: add #6321 * Changelog: add #6297 * Readme: update the support forum link anchor. Anchor changed when WordPress.org forums were updated to bbPress 2 * Readme: update list of a12s, it wasn't up to date anymore! * Changelog: add #6338 * Changelog: add #6337 * Changelog: add #6335 * Changelog: add #6333 * Testing List: first version of the 4.7 testing list. * Changelog: add #6332 * Changelog: add #6325 * Changelog: add #6326 * Changelog: add #6339 * Changelog: add #6342 * Changelog: add #6343 * Changelog: add #6346 * Changelog: add #6347 * Changelog: add #6279 * Changelog: add #6306 * Changelog: add #6312 * Changelog: add #6316 * Changelog: add #6171 * Changelog: add #6317 * Changelog: add #6246 * Changelog: add #6263 * Changelog: add #4220 * Changelog: add #5888 * Changelog: add #3406 * Changelog: add #3637 * Changelog: add #6320 * Changelog: add #5992 * Changelog: add #6322 * Changelog: add #6324 * Changelog: add #6352 * Changelog: add #6355 * Changelog: add #6360 * Changelog: add #6362 * Changelog: add #6369, #6382 * Changelog: add #6370 * Changelog: add #6375 * Changelog: add #6383 * Changelog: add #6384 * Changelog: add #6386 * Changelog: add #6395 * Changelog: add #6403 * Changelog: add #6406 * Changelog: add #6418 * Changelog: add #6419 * Changelog: add #6434 * Changelog: add #6446 * Changelog: add #6006 * Changelog: add #6096 * Changelog: add #6399 * Changelog: fix typo. @see #6331 (comment) * Changelog: add #6440 * Changelog: add #6443 * Changelog: add #6445 * Changelog: add #6463 * Changelog: add #6468 * Changelog: add #6471 * Changelog: add #6474 * Changelog: add #6480 * Changelog: add #6497 * Changelog: add #6499 * Changelog: add #6514 * Changelog: add #6267 * Changelog: add #5940 * Changelog: add #6492 * Changelog: add #5281 * Changelog: add #6327 * Changelog: add #6451 * Changelog: add #6525 * Changelog: add #6530
Fixes: #2658
Add additional padding to Sharedaddy buttons on mobile, to prevent Google Webmaster Tools reporting mobile usability issues, because the clickable elements are too close.