Skip to content

Merge branch '4.0-dev' into 4.0-resetToken#8

Merged
Arpit-24 merged 2211 commits intoArpit-24:4.0-resetTokenfrom
joomla:4.0-dev
Aug 2, 2020
Merged

Merge branch '4.0-dev' into 4.0-resetToken#8
Arpit-24 merged 2211 commits intoArpit-24:4.0-resetTokenfrom
joomla:4.0-dev

Conversation

@Arpit-24
Copy link
Copy Markdown
Owner

@Arpit-24 Arpit-24 commented Aug 1, 2020

No description provided.

chmst and others added 30 commits June 17, 2020 01:03
Co-authored-by: Brian Teeman <brian@teeman.net>
* [4.0] Normalising authentication cookie lang strings

* also in sys.ini
PR for #29621

apply the safari fix from the admin template #28921 to the installer

@nikosdion @PhilETaylor please test as I don't have access to safari
PR for #29677

This pr changes scss so you will need to node build.js --compile-css

The changes here ensure that the cursor maintains the i-beam on the text and then uses the pointer on the arrow
* [4.0] Media Manager modal toolbar

scss has been changed in this pr so you will need to node build.js --compile-css

### The problem
The toolbar buttons in the media manager modal eg when adding an intro image is displayed with the full colours and no spacing

### The solution
This could be technically wrong. It works but maybe there is a better way. It wraps the toolbar with the subhead div and adds a noshadow class

* Update administrator/components/com_media/tmpl/media/default.php

Co-authored-by: Quy <quy@fluxbb.org>

Co-authored-by: Quy <quy@fluxbb.org>
Simple typo on a comment can be merged on review
PR for #29725

Updates the path of the autoloader in the plugin description
Resolves #29318 AND #29575

this is a scss change so requires node build.js --compile-css
alikon and others added 29 commits July 26, 2020 00:00
* [4.0] mod_syndicate a11y and more

### Problem
1. the alt text contains the word image which is not recommended
2. the alt text is hardcoded and not translatable
3. When the text is displayed then the alt text is not needed as it does not convey any meaning
4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link

### Solution
1. remove the alt text completely and replace with empty alt
2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely
3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on

### Testing
If you dont already have a syndication module then create one

The changes are visible in the config of the module
#### Before

#### After

In the frontend the changes are only visible in the markup of the module

#### After - with Label

#### After - without label

* Update modules/mod_syndicate/tmpl/default.php

Co-authored-by: Quy <quy@fluxbb.org>

Co-authored-by: Quy <quy@fluxbb.org>
* [4.0] fix Templates : Edit style - unsaved menu assignments

* Correct variable $userId not $userid in save function

* Update administrator/components/com_templates/src/Model/StyleModel.php

Co-authored-by: SharkyKZ <sharkykz@gmail.com>

* Update administrator/components/com_templates/src/Model/StyleModel.php

Co-authored-by: SharkyKZ <sharkykz@gmail.com>

* Update administrator/components/com_templates/src/Model/StyleModel.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Update administrator/components/com_templates/src/Model/StyleModel.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Co-authored-by: SharkyKZ <sharkykz@gmail.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* complete the list of fields to render

* fix notice
* fixed issue #30024

* Update libraries/src/Toolbar/ToolbarButton.php

ty @Quy was wondering about that.

Co-authored-by: Quy <quy@fluxbb.org>

* remove space from before btn

* trying to isolate exact cause.
TEMPORARY working solution

* conversing with jbs

* fixes toolbar id issue.

* fixed unnecessary blank line

Co-authored-by: Quy <quy@fluxbb.org>
[4.0] Removing Hound and moving to Drone
* replace lost preview icon

* add admin preview support

* moved $client
* [4.0] [workflow] Translate title

* Title => Name
@Arpit-24 Arpit-24 merged commit abf4341 into Arpit-24:4.0-resetToken Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.