[4.0] Fix php notice when no version_id specified#29693
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Jun 19, 2020
PhilETaylor:29654
Merged
[4.0] Fix php notice when no version_id specified#29693wilsonge merged 2 commits intojoomla:4.0-devfrom PhilETaylor:29654
wilsonge merged 2 commits intojoomla:4.0-devfrom
PhilETaylor:29654
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
Quy
reviewed
Jun 18, 2020
administrator/components/com_contenthistory/src/Model/PreviewModel.php
Outdated
Show resolved
Hide resolved
Member
|
I have tested this item ✅ successfully on 25a6b56 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29693. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 25a6b56 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29693. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29693. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for part of Issue #29654 and a
Summary of Changes
Fix php notice when no version_id specified in faked/truncated url
Testing Instructions
Joomla 4
apply #29692
go to
http://127.0.0.1/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component&version_id=
Expected result
No PHP notice, no comparison
After PR should be
Actual result before PR
Documentation Changes Required
none