[4.0] Fix history version preview#29692

Merged

wilsonge merged 1 commit intojoomla:4.0-devfrom

SharkyKZ:j4/error/history-preview

Jun 19, 2020

Contributor

SharkyKZ commented Jun 18, 2020 •

edited

Loading

Fixes #29654.

Summary of Changes

Corrects class casing, fixing version preview on case sensitive filesystems.

Testing Instructions

Create and edit an article.
Click Versions button.
Select a version and click Preview.

Expected result

Preview displayed.

Actual result

Call to a member function load() on bool

Documentation Changes Required

No.


          Correct class name

896a8db

joomla-cms-bot added the PR-4.0-dev label

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

Contributor Author

SharkyKZ commented Jun 18, 2020

Those using JTable prefix are case insensitive. So they're fine for now.

This comment was marked as abuse.

Sign in to view

ChristineWk commented Jun 18, 2020

I have tested this item ✅ successfully on 896a8db

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29692.}

ChristineWk commented Jun 18, 2020

Confirm Actual Result before Patch.
@PhilETaylor With Patch: No message shown.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29692.}

This comment was marked as abuse.

Sign in to view

Member

particthistle commented Jun 18, 2020

I have tested this item ✅ successfully on 896a8db

- Specific expected result for the issue tested successfully and preview of version was displayed.

Confirmed that if URL @PhilETaylor prescribes is used, then there's still an offset error. However, why would someone want to manually fake a URL with no version ID value supplied - that would imply they know what the URL is trying to achieve, and that they would be expecting failure.

Not sure what the suggested solution should be there on that URL being used with no parameter? As it loads in a modal, should a direct access outside the modal trigger a die();?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29692.}

This comment was marked as abuse.

Sign in to view

Member

particthistle commented Jun 18, 2020

@PhilETaylor agree with the principle. And that it's hard than it sounds.

Code to suggest for this one escapes me at the second, and not just as it's 4am in Australia.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29692.}

This comment was marked as abuse.

Sign in to view

Member

richard67 commented Jun 18, 2020

I have tested this item ✅ successfully on 896a8db

3rd test is never bad ;-)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29692.}

richard67 removed the PR-4.0-dev label

Member

richard67 commented Jun 18, 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29692.}

joomla-cms-bot added the RTC label

richard67 added the PR-4.0-dev label

wilsonge merged commit 5c9dc94 into joomla:4.0-dev

Contributor

wilsonge commented Jun 19, 2020

Thanks!

joomla-cms-bot removed the RTC label

wilsonge added this to the Joomla 4.0 milestone

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request


          Correct class name (joomla#29692)

c1c4aaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet