Skip to content

[4.0] Fix redirect after deleting content history versions#29663

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/bug/history-delete
Jun 20, 2020
Merged

[4.0] Fix redirect after deleting content history versions#29663
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/bug/history-delete

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

Fixes #29653.

Summary of Changes

Corrects redirect after deleting content history version.

Testing Instructions

Create an article.
Edit and save it so a version history is saved.
Click Versions button in the toolbar.
Select the older version. Click Delete.

Expected result

Redirected back to a list containing remaining versions.

Actual result

Redirected to an empty page. PHP notices are shown:

Notice: Undefined offset: 1 in administrator\components\com_contenthistory\src\Model\HistoryModel.php on line 419
Notice: Undefined offset: 1 in administrator\components\com_contenthistory\tmpl\history\modal.php on line 29
Notice: Undefined offset: 1 in administrator\components\com_contenthistory\tmpl\history\modal.php on line 31

Documentation Changes Required

No.

@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 3517ff2

Message: "History version deleted".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29663.

@chmst
Copy link
Copy Markdown
Contributor

chmst commented Jun 17, 2020

I have tested this item ✅ successfully on 3517ff2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29663.

@Quy Quy removed the PR-4.0-dev label Jun 17, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 17, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29663.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 17, 2020
@Quy Quy added the PR-4.0-dev label Jun 17, 2020
@wilsonge wilsonge merged commit ffe52af into joomla:4.0-dev Jun 20, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 20, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 20, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants