Make ToolbarHelper::back rtl compliant#29669
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Jun 17, 2020
Ruud68:toolbarbackrtl
Merged
Make ToolbarHelper::back rtl compliant#29669wilsonge merged 2 commits intojoomla:4.0-devfrom Ruud68:toolbarbackrtl
wilsonge merged 2 commits intojoomla:4.0-devfrom
Ruud68:toolbarbackrtl
Conversation
infograf768
reviewed
Jun 17, 2020
Contributor
|
Thanks! |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #29638 (comment)
Summary of Changes
make ToolbarHelper::back() rtl compliant
Testing Instructions
Add ToolbarHelp::back() to your view
test if position and direction of arrow icon is correct in both rtl and ltr languages
Expected result
arrow icon should be > on rtl and < on ltr languages
Actual result
arrow icon is always <
Documentation Changes Required
no