It should handle RTL.

It should handle RTL.

Not sure about that. Example: using Open a New Tab in a browser always creates the tab to the right of the open one.

Switch to Persian.
Enable Workflows.
Edit Basic Workflow.
Click Stages badge.
See back button using right-arrow.

This PR sets it to always be left-arrow so this method cannot be used in RTL.

Plus, this is about going back and not opening a new tab.

OK

Open a New Tab in a browser always creates the tab to the right of the open one.

Sorry that's not correct. At least in chrome the new window opens to the left in both hebrew and arabic

At least in chrome the new window opens to the left in both hebrew and arabic

Good to know.

LOL... this is just a replacement of a broken icon, not about adding rtl to an existing button that doesn't have rtl.
@Quy what you are referring to in the workflow component is NOT using the ToolbarHelper::back() but constructs the link that the page is routed back to. A lot of code that could have been implemented easier...

I have no idea about rtl so I also have no clue as to whether a back button in rtl should be 'back >' or 'back <' or '>back' or '< back' (the last one as it currently is in J3)

I am just replacing the < icon with the < icon making the assumption that < is the correct icon as that was always the case

I have tested this item ✅ successfully on f96c61b

RTL can be fixed in a separate PR.

RTL can be fixed in a separate PR.

I can do it in this PR, but as said, then somebody should set the requirement as to the position / direction of the <, >

See my screenshot above for RTL pointing to the right. Thank you!

@Ruud68 For LTR/RTL handling you could do it like here:

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_workflow/src/View/Transitions/HtmlView.php#L166

$arrow = Factory::getLanguage()->isRtl() ? 'arrow-right' : 'arrow-left';

and then

$bar->appendButton('Link', $arrow, $alt, $href);

or maybe all in one:

$bar->appendButton('Link', Factory::getLanguage()->isRtl() ? 'arrow-right' : 'arrow-left', $alt, $href);

I prefer in 2 lines. 😺

Thanks!

@Ruud68 Will you make a new PR for RTL?

@richard67 yes, will do tomorrow