[4.0] Remove reference to non-existing class#29686
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Jun 19, 2020
SharkyKZ:j4/cleanup/buttonsinuserpage
Merged
[4.0] Remove reference to non-existing class#29686wilsonge merged 2 commits intojoomla:4.0-devfrom SharkyKZ:j4/cleanup/buttonsinuserpage
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/cleanup/buttonsinuserpage
Conversation
Member
|
@SharkyKZ It seems Appveyor and Drone didn't get the base branch change. Maybe they will if you commit a change, dummy change or update to a change in 4.0-dev, if any, but maybe it's the easiest thing if you redo the PR. Or someone merges it by review. |
Contributor
Author
|
Branch updated. |
Member
|
I have tested this item ✅ successfully on a5147c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29686. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on a5147c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29686. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29686. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes import of
Joomla\Plugin\System\Webauthn\PluginTraits\ButtonsInUserPagewhich doesn't exist.Testing Instructions
Code review.
Documentation Changes Required
No.