Fix webservice plugin to show super user group#29649
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jun 17, 2020
Merged
Conversation
Contributor
Author
|
@nikosdion tagging this so you can review |
Contributor
|
I have tested this item ✅ successfully on b7157e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649. |
Contributor
|
I have tested this item ✅ successfully on b7157e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649. |
Contributor
|
I have tested this item ✅ successfully on b7157e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649. |
Contributor
|
Looks good to me. |
Contributor
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649. |
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Allow Super User groups to always show in the webservices plugin so that they can view their api tokens.
Testing Instructions
View API plugin. select some user groups. currently super user doesn't show. Save some other user groups to access the token. Before patch a super user loose their ability to view the API token. After patch they can still view the token.
Documentation Changes Required
None