Skip to content

[4.0] Add padding to external link icon#30250

Merged
HLeithner merged 4 commits intojoomla:4.0-devfrom
Quy:29335-icon-padding
Aug 1, 2020
Merged

[4.0] Add padding to external link icon#30250
HLeithner merged 4 commits intojoomla:4.0-devfrom
Quy:29335-icon-padding

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented Jul 31, 2020 •
edited
Loading

Pull Request for Issue #29335 .

Summary of Changes

Add padding to external link icon.

In Help Dashboard, padding is slightly wider due to markup, but at least it is better with this PR than before.

Testing Instructions

Run npm run build:css or download the installer package at the bottom of the page.

Navigate backend to see external links in:

  • Post Installation Messages
  • reCAPTCHA plugin
  • Two Factor Authentication - Google Authenticator plugin
  • Content Security Policy configuration and select Custom (see screenshots)
  • Extensions > Install from Web
  • Help Dashboard

Actual result BEFORE applying this Pull Request

29335-before

Expected result AFTER applying this Pull Request

29335-before

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jul 31, 2020
@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 1, 2020

Test results: OK = successfully

Post Installation Messages OK
reCAPTCHA plugin OK
Two Factor Authentication - Google Authenticator plugin OK
Content Security Policy configuration and select Custom (see screenshots) OK
Extensions > Install from Web OK

Help Dashboard OK / NOK !?

Before testing: already a little space
screen shot 2020-08-01 at 11 52 35

After testing: just a little more space
screen shot 2020-08-01 at 11 52 35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30250.

@chmst
Copy link
Copy Markdown
Contributor

chmst commented Aug 1, 2020

I have tested this item ✅ successfully on 2a1962c

Better than before, especially on the install-from-web.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30250.

@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Aug 1, 2020

@Quy can you fix the cs please https://ci.joomla.org/joomla/joomla-cms/34360/1/24

@hans2103
Copy link
Copy Markdown
Contributor

hans2103 commented Aug 1, 2020

@Quy
change the position of padding-right.

administrator/templates/atum/scss/blocks/_global.scss
--
4 | 175:3  ✖  Expected "padding-right" to come before "content"   order/properties-order

@Quy
Copy link
Copy Markdown
Contributor Author

Quy commented Aug 1, 2020

@sandewt @hans2103 Please test as it. The Help Dashboard and several other places can be fixed in a separate PR since changes will be more extensive. Thanks.

@HLeithner HLeithner merged commit ccef11b into joomla:4.0-dev Aug 1, 2020
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Aug 1, 2020

Thanks

@HLeithner HLeithner added this to the Joomla 4.0 milestone Aug 1, 2020
@Quy Quy deleted the 29335-icon-padding branch August 1, 2020 22:59
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@sakiss
[4.0] Add padding to external link icon (joomla#30250)
7b04c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Quy @sandewt @chmst @HLeithner @hans2103 @joomla-cms-bot