Skip to content

[4.0][api][com_content] render metafields "metakey", "metadesc" and "metadata" and fields "featured" and "access"#30134

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
alikon:patch-124
Jul 25, 2020
Merged

[4.0][api][com_content] render metafields "metakey", "metadesc" and "metadata" and fields "featured" and "access"#30134
wilsonge merged 3 commits intojoomla:4.0-devfrom
alikon:patch-124

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Jul 18, 2020 •
edited
Loading

Pull Request for Issue #30130, #30135

Summary of Changes

render metafields: metakey, metadesc, metadata, featured, access

Testing Instructions

edit an article
add content to metakey, metadesc, metadata fields
save
call the api

--for article list
{{base_url}}api/index.php/v1/content/article

--for article item
{{base_url}}api/index.php/v1/content/article/{id}

Actual result BEFORE applying this Pull Request

no render of metakey, metadesc, metadata, featured, access, fields

Expected result AFTER applying this Pull Request

Screenshot from 2020-07-18 07-26-26

Screenshot from 2020-07-19 10-46-20

Documentation Changes Required

probably ?

This was referenced Jul 18, 2020
Closed
Closed
@particthistle
Copy link
Copy Markdown
Member

particthistle commented Jul 18, 2020 •
edited
Loading

I have tested this item ✅ successfully on 060df8d

Tested successfully.

BEFORE Applying patch:
No metafield data displayed.

AFTER Applying patch:
Metafield data displayed in the data.
image

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@chetanmadaan
Copy link
Copy Markdown

chetanmadaan commented Jul 18, 2020

I have tested this item ✅ successfully on 060df8d
Before:
image

After:
image

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 18, 2020

@chetanmadaan It seems you have just added your test result here on GitHub. It would have been better if you had done it on the issue tracker here https://issues.joomla.org/tracker/joomla-cms/30134 using the "Test this" button, then the test would be counted correctly. This time I have done this for you by setting your test result in the issue tracker, so here all is ok now. But it would be great if you test a PR next time use the issue tracker for setting the test result. Thanks in advance, and thanks for testing here.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 18, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 18, 2020
@chetanmadaan
Copy link
Copy Markdown

chetanmadaan commented Jul 18, 2020

I see the test this button. My bad.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 18, 2020

@chetanmadaan All fine. Now as it has 2 good tests, the PR is RTC, means "ready to commit", so it will be merged sooner or later. Thanks for reporting the issue and testing the PR.

@chetanmadaan
Copy link
Copy Markdown

chetanmadaan commented Jul 18, 2020

Well, Thank you for being the mentor on the testing bit!

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 19, 2020

@alikon Don't forget to update testing instructions ;-) Ping us when ready.

@alikon alikon removed the RTC This Pull Request is Ready To Commit label Jul 19, 2020
@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Jul 19, 2020

ready to be re-tested it solves #30135 too

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 19, 2020
@alikon alikon mentioned this pull request Jul 19, 2020
Closed
@alikon alikon removed the RTC This Pull Request is Ready To Commit label Jul 19, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 19, 2020

Back to pending due to recent changes.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@richard67 richard67 added the RTC This Pull Request is Ready To Commit label Jul 19, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 19, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 19, 2020

I have tested this item ✅ successfully on 6d660f3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 19, 2020

With blog sample data:

  1. Articles list
    j4-pr-30134_1

  2. Single article
    j4-pr-30134_2

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 19, 2020

@particthistle @chetanmadaan Could you test again after last changes? Thanks in advance.

@richard67 richard67 changed the title [4.0][api][com_content] render metafields [4.0][api][com_content] render metafields "metakey", "metadesc" and "metadata" and fields "featured" and "access" Jul 19, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 19, 2020

@particthistle @chetanmadaan P.S.: Note that testing instructions have been changed due to more fields being added with this PR now.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jul 19, 2020

I have tested this item ✅ successfully on 6d660f3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@Quy Quy added the RTC This Pull Request is Ready To Commit label Jul 19, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jul 19, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@chetanmadaan
Copy link
Copy Markdown

chetanmadaan commented Jul 20, 2020

I have tested this item ✅ successfully on 6d660f3

Works! Featured and access column show up fine now.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.

@chetanmadaan
Copy link
Copy Markdown

chetanmadaan commented Jul 20, 2020

Thank you @richard67 @alikon

@chetanmadaan chetanmadaan mentioned this pull request Jul 20, 2020
Closed
@wilsonge wilsonge merged commit 9b35d6c into joomla:4.0-dev Jul 25, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jul 25, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 25, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 25, 2020
@alikon alikon deleted the patch-124 branch July 26, 2020 06:16
@alikon alikon mentioned this pull request Jul 27, 2020
Merged
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@alikon @sakiss
[4.0][api][com_content] render metafields "metakey", "metadesc" and "…
63faf73 
…metadata" and fields "featured" and "access" (joomla#30134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@alikon @particthistle @chetanmadaan @richard67 @Quy @wilsonge @joomla-cms-bot