[4.0] Media Manager modal toolbar#29681
Merged
Quy merged 2 commits intojoomla:4.0-devfrom Jun 18, 2020
Merged
Conversation
scss has been changed in this pr so you will need to node build.js --compile-css ### The problem The toolbar buttons in the media manager modal eg when adding an intro image is displayed with the full colours and no spacing ### The solution This could be technically wrong. It works but maybe there is a better way. It wraps the toolbar with the subhead div and adds a noshadow class
Member
|
I have tested this item ✅ successfully on f635694 But it works well. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29681. |
Member
|
I have tested this item ✅ successfully on f635694 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29681. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29681. |
Contributor
Author
|
Thank @C-Lodder I wasn't sure at all if it was technically correct |
Quy
reviewed
Jun 18, 2020
Co-authored-by: Quy <quy@fluxbb.org>
Contributor
Author
|
thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* [4.0] Media Manager modal toolbar scss has been changed in this pr so you will need to node build.js --compile-css ### The problem The toolbar buttons in the media manager modal eg when adding an intro image is displayed with the full colours and no spacing ### The solution This could be technically wrong. It works but maybe there is a better way. It wraps the toolbar with the subhead div and adds a noshadow class * Update administrator/components/com_media/tmpl/media/default.php Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Quy <quy@fluxbb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scss has been changed in this pr so you will need to node build.js --compile-css
The problem
The toolbar buttons in the media manager modal eg when adding an intro image is displayed with the full colours and no spacing
The solution
This could be technically wrong. It works but maybe there is a better way. It wraps the toolbar with the subhead div and adds a noshadow class
before
after