Merged
Conversation
Member
Author
|
Note: we may consider to do the same for Transitions although none are provided by core as lang constants. For another patch after discussion |
Member
Author
|
Modified "Title" to "Name" to fit with field label and column heading |
|
I have tested this item ✅ successfully on 710dfd9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30231. |
Member
|
I have tested this item ✅ successfully on 710dfd9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30231. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30231. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* [4.0] [workflow] Translate title * Title => Name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30229
Summary of Changes
Translating Workflow list items and stages when editing them, as done for custom admin menus
Testing Instructions
Patch and edit Basic workflow
administrator/index.php?option=com_workflow&view=workflow&layout=edit&id=1&extension=com_content.articlethen edit Basic stage
administrator/index.php?option=com_workflow&view=stages&workflow_id=1&extension=com_content.articleActual result BEFORE applying this Pull Request
As titles in db are lang constants, they are displayed as such. No translation is provided, although the translation is present in the list. The fact that these are constants is voluntary to cope with different languages.
Expected result AFTER applying this Pull Request