[4.0] Fix Atum Safari not displaying svg background when using choices#29675
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Jun 17, 2020
Merged
[4.0] Fix Atum Safari not displaying svg background when using choices#29675Quy merged 1 commit intojoomla:4.0-devfrom
Quy merged 1 commit intojoomla:4.0-devfrom
Conversation
This was referenced Jun 17, 2020
This comment was marked as abuse.
This comment was marked as abuse.
|
I have tested this item ✅ successfully on 00a94b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29675. |
Member
Author
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29675. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #29658
Summary of Changes
Safari and possibly some other browsers do not like combining background color and url of image. In our case the
select-bg.svgas well asselect-bg-rtl.svgThis PR separates both.
Testing Instructions
See #29658
Make sure that all caches are deleted after patching.
This needs npm to test
After patch