Skip to content

[4.0] Fix WebAuthn white icons#29704

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
C-Lodder:patch-1
Jun 19, 2020
Merged

[4.0] Fix WebAuthn white icons#29704
wilsonge merged 1 commit intojoomla:4.0-devfrom
C-Lodder:patch-1

Conversation

@C-Lodder
Copy link
Copy Markdown
Member

@C-Lodder C-Lodder commented Jun 19, 2020 •
edited
Loading

Pull Request for Issue #29700

Summary of Changes

  • Replace the icon- prefix with fa-
  • Remove the icon-white class so that icons inherit the colour of the parent

Testing Instructions

Code review

@C-Lodder C-Lodder mentioned this pull request Jun 19, 2020
Closed
@PhilETaylor

This comment was marked as abuse.

Sign in to view
1 similar comment
@PhilETaylor

This comment was marked as abuse.

Sign in to view
@C-Lodder
Copy link
Copy Markdown
Member Author

C-Lodder commented Jun 19, 2020

Thanks. Link updated

@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Jun 19, 2020

I have tested this item ✅ successfully on c0a5a19

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29704.

@wilsonge wilsonge merged commit 488e559 into joomla:4.0-dev Jun 19, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jun 19, 2020

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 19, 2020
@C-Lodder C-Lodder deleted the patch-1 branch June 19, 2020 21:45
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@C-Lodder @sakiss
Update manage.php (joomla#29704)
ba691f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@C-Lodder @PhilETaylor @ChristineWk @wilsonge @joomla-cms-bot