Skip to content

[4.0] Modal button height#29715

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
brianteeman:19jun1
Jun 20, 2020
Merged

[4.0] Modal button height#29715
Quy merged 1 commit intojoomla:4.0-devfrom
brianteeman:19jun1

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Resolves #29318 AND #29575

this is an scss change so requires node build.js --compile-css

before

image

after

image

image

Resolves joomla#29318 AND joomla#29575

this is a scss change so requires node build.js --compile-css
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 20, 2020

I have tested this item ✅ successfully on ad5a4ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29715.

1 similar comment
@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on ad5a4ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29715.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29715.

@richard67 richard67 removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 20, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 20, 2020
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 20, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jun 20, 2020
@Quy Quy merged commit 02c1f47 into joomla:4.0-dev Jun 20, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 20, 2020
@brianteeman
Copy link
Copy Markdown
Contributor Author

thx

@brianteeman brianteeman deleted the 19jun1 branch June 20, 2020 17:53
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Resolves joomla#29318 AND joomla#29575

this is a scss change so requires node build.js --compile-css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants