[4.0] Reduced duplicated code in ProfileModel.#30194
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jul 29, 2020
Merged
Conversation
|
I have tested this item ✅ successfully on 5b5c43d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30194. |
1 similar comment
|
I have tested this item ✅ successfully on 5b5c43d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30194. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30194. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #30152 (comment), the method
ProfileModel::saveis mostly a copy of its parentUserModel::save. This is going to lead to problems (just like the issue fixed in #30152), because every time someone changes the methodUserModel::save, they need to remember aboutProfileModeland might need to include the same change there.Summary of Changes
By calling the parent method, code duplication is reduced. As the form in the profile view is a reduced form of the user edit form, some values need to be changed, because the validation inside
UserModel::savewould fail otherwise.Testing Instructions
Expected result AFTER applying this Pull Request
Everything should still work like before.
Documentation Changes Required
None
/cc @SharkyKZ