This repository was archived by the owner on May 15, 2024. It is now read-only.
Screenshots #744 -> #613#1356
Merged
mattleibow merged 68 commits intodev/add-media-pickerfrom Aug 25, 2020
Merged
Conversation
…same media file as in other struct # Conflicts: # Xamarin.Essentials/Platform/Platform.android.cs
…Essentials into feature/Screenshot
…to avoid ambiguieties on uwp.
…Essentials into feature/Screenshot
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md In doing some performance testing with builds in VS 2019, I noticed: 115 ms _ConvertPdbFiles 1 calls And looking at files were converted: ConvertDebuggingFiles Parameters Files C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.pdb [Output] ConvertedFiles: C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.dll The Xamarin.Essentials NuGet package is shipping a non-portable PDB file. This is a Windows-specific format that Mono doesn't support. Xamarin.Android runs a tool called `pdb2mdb` when it encounters a non-portable PDB file so symbols be converted to something that Mono can use. If you have `DebugType=full` or `DebugType=pdbonly`, Xamarin.Android has to do this extra work to convert it. I see no drawbacks to just use `DebugType=portable` in this project all the time? Since Xamarin.Essentials uses sourcelink, I double-checked and they support portable PDBs: https://github.com/dotnet/sourcelink#prerequisites-for-net-projects I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a bit more detail on symbol files there if you need more info: xamarin/Xamarin.Forms#4201
…ic cache director and use correct path for file provider. (#789)
* Check for null MainView * Use the ActionSendMultiple on android for multi-attachments
…to avoid ambiguieties on uwp.
…Essentials into feature/Screenshot
…ot feature, changed method signature to be compatible with the picker as suggested. Also renamed mediafile to screenshotfile
pictos
reviewed
Aug 20, 2020
Contributor
pictos
left a comment
There was a problem hiding this comment.
I like it, I just point some places that, maybe we can use ConfigureAwait(false).
mattleibow
commented
Aug 21, 2020
Comment on lines
+8
to
+9
| public static bool IsCaptureAvailable | ||
| => PlatformCanCapture; |
Member
Author
There was a problem hiding this comment.
Not sure what we want to do here...
I see the media picker has a public property, but the app actions does not.
Contributor
There was a problem hiding this comment.
Just as a heads up, as the audio recording pr is quite similar with regards to public api. There exists a similar property on that branch, CanRecordAudio. IsFeatureSupported is probably more universally suited for this?
Member
Author
There was a problem hiding this comment.
Thanks for that. I think we might be going for an Is<operation>Available naming convention. But, I need to confirm with @Redth and @jamesmontemagno what this will be.
`bmp` was inaccessible in some cases at this point and getting the `PixelWidth` was throwing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Merge the #744 PR into the #613 PR to see what things are needed to change to merge the result types.
Bugs Fixed
API Changes
Behavioral Changes
New screenshot API.
PR Checklist