Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

GH-788 -> Fix for Pre-N devices for file sharing#789

Merged
jamesmontemagno merged 1 commit intomasterfrom
bug/issue-788
May 29, 2019
Merged

GH-788 -> Fix for Pre-N devices for file sharing#789
jamesmontemagno merged 1 commit intomasterfrom
bug/issue-788

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

…ic cache director and use correct path for file provider.

Description of Change

Describe your changes here.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

None pre-N devices with files in internal cache directory we must copy it to public since it doesn't use file provider.

Behavioral Changes

For pre-n devices we must

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

…ic cache director and use correct path for file provider.
@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label May 17, 2019
@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone May 17, 2019
@jamesmontemagno jamesmontemagno requested a review from Redth May 17, 2019 19:03
@ghost
Copy link
Copy Markdown

ghost commented May 17, 2019

Docs Build status updates of commit fc1c6aa:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples.Android/Resources/Resource.designer.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.android.cs ✅Succeeded
Xamarin.Essentials/Types/FileProvider.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Copy Markdown
Contributor

@newky2k newky2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs locally on a device

@newky2k newky2k added ready-to-merge Review completed, Ready for API review and merge and removed awaiting-review This PR needs to have a set of eyes on it labels May 29, 2019
@jamesmontemagno jamesmontemagno merged commit 65a03c1 into master May 29, 2019
@jamesmontemagno jamesmontemagno deleted the bug/issue-788 branch May 29, 2019 23:51
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
…ic cache director and use correct path for file provider. (xamarin#789)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants