Fixes #745 to return real metrics, not app metrics on display.#749
Fixes #745 to return real metrics, not app metrics on display.#749jamesmontemagno merged 6 commits intomasterfrom
Conversation
|
OPS Build status updates of commit ca36046: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Docs Build status updates of commit 3c63626: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
| static DisplayInfo GetMainDisplayInfo() | ||
| { | ||
| var displayMetrics = Platform.AppContext.Resources?.DisplayMetrics; | ||
| var displayMetrics = new DisplayMetrics(); |
There was a problem hiding this comment.
It might be better to wrap this in a using to dispose of the object sooner. Not sure how big this object is.
There was a problem hiding this comment.
Fixed up :) let me know what you think.
|
Docs Build status updates of commit e8f62f0: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Docs Build status updates of commit 5baf369: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
newky2k
left a comment
There was a problem hiding this comment.
Tested and builds and runs on real device
|
Docs Build status updates of commit 0a12af0: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
…xamarin#749) * Fixes xamarin#745 to return real metrics, not app metrics on display. * Add using statements to cleanup displays and metrics
Description of Change
Uses real device metrics instead of app.
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
Behavioral Changes
Will return different device metrics, but are correct to match iOS/UWP
PR Checklist