Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Fixes #794 try to use original string first else absolute for NSUrl#795

Merged
jamesmontemagno merged 4 commits intomasterfrom
bug/issue-gh-794
May 31, 2019
Merged

Fixes #794 try to use original string first else absolute for NSUrl#795
jamesmontemagno merged 4 commits intomasterfrom
bug/issue-gh-794

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

Description of Change

If not encoded string then NSUrl gets mad so try original first for launcher else use absolute

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

None

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone May 22, 2019
@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label May 22, 2019
@jamesmontemagno jamesmontemagno requested a review from Redth May 22, 2019 22:14
@ghost
Copy link
Copy Markdown

ghost commented May 22, 2019

Docs Build status updates of commit f353f9e:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/Launcher_Tests.cs ✅Succeeded
Xamarin.Essentials/Launcher/Launcher.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 30, 2019

Docs Build status updates of commit 27da8a1:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/Launcher_Tests.cs ✅Succeeded
Xamarin.Essentials/Launcher/Launcher.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Docs Build status updates of commit c7171e5:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/Launcher_Tests.cs ✅Succeeded
Xamarin.Essentials/Launcher/Launcher.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Copy Markdown
Contributor

@newky2k newky2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally

@newky2k newky2k added ready-to-merge Review completed, Ready for API review and merge and removed awaiting-review This PR needs to have a set of eyes on it labels May 31, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Docs Build status updates of commit dcf6fd4:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/Launcher_Tests.cs ✅Succeeded
Xamarin.Essentials/Launcher/Launcher.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno merged commit c32839b into master May 31, 2019
@jamesmontemagno jamesmontemagno deleted the bug/issue-gh-794 branch May 31, 2019 19:03
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants