Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Fixes issue https://github.com/xamarin/Essentials/issues/808#809

Merged
jamesmontemagno merged 2 commits intoxamarin:masterfrom
nullpotent:master
Jun 17, 2019
Merged

Fixes issue https://github.com/xamarin/Essentials/issues/808#809
jamesmontemagno merged 2 commits intoxamarin:masterfrom
nullpotent:master

Conversation

@appsourcers
Copy link
Copy Markdown
Contributor

Description of Change

After calling Browser.OpenAsync with the URL that contained a fragment part, the fragment part was being omitted as a result of a call to Browser.EscapeUri.

Changed Browser.EscapeUri to include the fragment part of the escaped URL as its last part.
See RFC 3986

Bugs Fixed

API Changes

None

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@msftclas
Copy link
Copy Markdown

msftclas commented Jun 11, 2019

CLA assistant check
All CLA requirements met.

@ghost
Copy link
Copy Markdown

ghost commented Jun 11, 2019

Docs Build status updates of commit 632e234:

✅ Validation status: passed

File Status Preview URL Details
Tests/Browser_Tests.cs ✅Succeeded
Xamarin.Essentials/Browser/Browser.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Copy Markdown
Collaborator

@jamesmontemagno jamesmontemagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Copy Markdown

ghost commented Jun 13, 2019

Docs Build status updates of commit 4dc4173:

✅ Validation status: passed

File Status Preview URL Details
Tests/Browser_Tests.cs ✅Succeeded
Xamarin.Essentials/Browser/Browser.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno added this to the 1.2.0 milestone Jun 13, 2019
@jamesmontemagno jamesmontemagno requested a review from Redth June 14, 2019 17:35
@newky2k newky2k added the ready-to-merge Review completed, Ready for API review and merge label Jun 17, 2019
@jamesmontemagno jamesmontemagno merged commit 5d25708 into xamarin:master Jun 17, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
nickrandolph pushed a commit to builttoroam/Essentials that referenced this pull request Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants