Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Add a Media Picker#613

Merged
Redth merged 161 commits intodevelopfrom
dev/add-media-picker
Sep 1, 2020
Merged

Add a Media Picker#613
Redth merged 161 commits intodevelopfrom
dev/add-media-picker

Conversation

@mattleibow
Copy link
Copy Markdown
Member

@mattleibow mattleibow commented Nov 7, 2018 •
edited
Loading

Adding a media picker...

With the new file type, there may be cause to evaluate the file / attachment types in #129, #130 and #416

Redth and others added 30 commits November 2, 2018 15:14
@Redth
Rename AppInfo.OpenSettings -> ShowSettingsUI
db12561 
Fixes #567
@Redth
Missed one docs rename
34c262b
@mattleibow
Added back a missing using.
0a46328
@jamesmontemagno
Fixed up Clipboard API! Updated everything SetTextAsync.
d393957 
Update xunit test runners
@jamesmontemagno
Updates Connectivity APIs from the review! got rid of Other made it u…
32e0d14 
…nknown, removed WiMAX and updated Profiles to ConnectionProfiles
@jamesmontemagno
Change MapKey to Platform.MapServiceToken only for UWP
07962c5
@mattleibow @jamesmontemagno
Dropping the version of the device runner until we can figure out wha…
7367dae 
…t is broken on UWP (#596)
@jamesmontemagno
Merge branch 'dev/api-fix' into dev/api-fix-569
881ba54
@mattleibow @jamesmontemagno
Update docs/en/FrameworksIndex/xamarin-essentials-uwp.xml
68155eb 
Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com>
@jamesmontemagno
Fix spacing
49db077
@mattleibow
Merge pull request #597 from jamesmontemagno/dev/api-fix-573
1f093d9 
Change MapKey to Platform.MapServiceToken only for UWP
@mattleibow
Merge pull request #595 from jamesmontemagno/dev/api-fix-570
2fe4bed 
GH-570: Updates Connectivity APIs from the review!
@mattleibow
Updated DOCS!
36c53af
@jamesmontemagno
Added Default and set it to Medium
4599c20
@mattleibow
Merge pull request #594 from jamesmontemagno/dev/api-fix-569
1f04307 
GH-569: Fixed up Clipboard API! Updated everything SetTextAsync.
@mattleibow @jamesmontemagno
[Platform] Remove the Platform for .net standard since it does nothing (
de6bf49 
#592)

- closes #579
@mattleibow @jamesmontemagno
GH-583: [api-fix] Power / Battery (#591)
98c4a9e 
* Move the `Power` members into `Battery` Closes #583

* [Battery] If the charge can be determined, return 1.0
 - if the device is on, then it must have some charge
 - chances are, the issue is that there is no battery at all (on power)
 - closes #583
@mattleibow
Merged the PR
3219cc6
@mattleibow
Merge pull request #598 from jamesmontemagno/dev/api-fix-574
7e980ad 
GH-574: Added Default and set it to Medium
@Redth @jamesmontemagno
GH-568: [api-fix] Browser (#589)
b639765 
* OpenAsync returns Task<bool>

Also on iOS we can take advantage of some async methods like PresentViewControllerAsync now.

* Update API docs

* Update Browser.shared.cs
@mattleibow
re-gen docs
f24a7f2
@jamesmontemagno
Merge pull request #1 from xamarin/dev/api-fix
da77177 
Dev/api fix
@mattleibow
Generated docs
6f5b46f
@mattleibow
Revert this to avoid conflicts
a1d7038
@jamesmontemagno
Add in DeviceIdiom and DevicePlatform
e3a7860
@mattleibow
Merge pull request #600 from jamesmontemagno/dev/api-fix-572
c2fdf1b 
GH-572: Fix up device info with new fancy struct
@mattleibow
Updated the docs and added a .gitattributes to control the line endings
2d55930
@mattleibow
Renamed SpeakSettings to SpeechOptions. Closes #580
3a5ecb7
@mattleibow
Add docs about HTML emails not supported on UWP. Closes #578
06f6e2b
@mattleibow
[Map] Fixed the type names and enum values. Closes #576
1f412f2
@mattleibow
Copy link
Copy Markdown
Member Author

mattleibow commented Aug 17, 2020

I am going to try merge the FilePickerResult and MediaPickerResult types into a single FileResult so that we can reduce duplication. Also, when the #508 gets merged, we can use the same type.

There is the ReadOnlyFile type, but there ight be a case where the picker result is not readonly... This may need investigation...

@mattleibow mattleibow changed the title [WIP] Add a Media Picker Add a Media Picker Aug 20, 2020
@mattleibow mattleibow mentioned this pull request Aug 20, 2020
Merged
5 tasks
@Redth Redth removed need-more-information Need more information to investigate a bug or proposal needs-more-discussion This needs more discussion or info before discussing it as a proposal. needs-specifications Accepted feature/enhancement and needs specification. proposal Proposed feature or enhancement. labels Aug 27, 2020
@Redth Redth merged commit dc4c3c9 into develop Sep 1, 2020
@Redth Redth deleted the dev/add-media-picker branch September 1, 2020 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Redth Redth Awaiting requested review from Redth

@jamesmontemagno jamesmontemagno Awaiting requested review from jamesmontemagno

1 more reviewer

@Mrnikbobjeff Mrnikbobjeff Mrnikbobjeff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattleibow mattleibow

Labels

awaiting-review This PR needs to have a set of eyes on it DO-NOT-MERGE Don't merge it.... don't do it! in-progress Actively being worked on.

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.