Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Adding an IsSupported property#1362

Merged
Redth merged 2 commits intodev/add-media-pickerfrom
dev/media-shot
Sep 1, 2020
Merged

Adding an IsSupported property#1362
Redth merged 2 commits intodev/add-media-pickerfrom
dev/media-shot

Conversation

@mattleibow
Copy link
Copy Markdown
Member

Description of Change

Adding an IsSupported property to MediaPicker and Screenshot.

I also moved the check for Android to the actual inline logic because this is a window flag that can change at any time, so rather check when using it. This is also not available when navigating, so any view setup logic will be incorrect.

Bugs Fixed

  • Related to issue #

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

If there is an entirely new API, then you can use a more verbose style:

public static class NewClass {
    public static int SomeProperty { get; set; }
    public static void SomeMethod(string value);
}

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

Moved the Android flag check as this is editable
Comment thread Xamarin.Essentials/Screenshot/Screenshot.android.cs Outdated
@Redth Redth merged commit dadeb41 into dev/add-media-picker Sep 1, 2020
@Redth Redth deleted the dev/media-shot branch September 1, 2020 13:11
@jamesmontemagno jamesmontemagno added this to the 1.6.0 milestone Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants