Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

GH-569: Fixed up Clipboard API! Updated everything SetTextAsync.#594

Merged
mattleibow merged 2 commits intoxamarin:dev/api-fixfrom
jamesmontemagno:dev/api-fix-569
Nov 2, 2018
Merged

GH-569: Fixed up Clipboard API! Updated everything SetTextAsync.#594
mattleibow merged 2 commits intoxamarin:dev/api-fixfrom
jamesmontemagno:dev/api-fix-569

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

Description of Change

Fix Clipboard API.

Bugs Fixed

API Changes

Changed:

  • void Clipboard.SetText(string) -> Task Clipboard.SetTextAsync(string)

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Nov 2, 2018
@jamesmontemagno jamesmontemagno added this to the 1.0.0 milestone Nov 2, 2018
@ghost

This comment has been minimized.

Copy link
Copy Markdown
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revert the csproj changes for the NuGet versions

@jamesmontemagno jamesmontemagno dismissed mattleibow’s stale review November 2, 2018 22:57

DONT TELL ME! tehehe fixed!

@ghost

This comment has been minimized.

@mattleibow mattleibow merged commit 1f04307 into xamarin:dev/api-fix Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants