Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Screenshot API#508

Closed
pictos wants to merge 10 commits intoxamarin:masterfrom
pictos:master
Closed

Screenshot API#508
pictos wants to merge 10 commits intoxamarin:masterfrom
pictos:master

Conversation

@pictos
Copy link
Copy Markdown
Contributor

@pictos pictos commented Sep 16, 2018

Description of Change

Adds new feature for screenshot.

Proposal

API Changes

Added:

  • Task CaptureAsync(ScreenOutputType type, string fileName)

  • Task<byte[]> GetImageBytesAsync(ScreenOutputType type)

  • enum ScreenOutputType

PR Checklist

  • [ x ] Has samples (if omitted, state reason in description)
  • [ x ] Rebased on top of master at time of PR
  • [ x ] Changes adhere to coding standard
  • [ x ] Updated documentation ([see walkthrough]

_Add ScreenShot in Essentials;
_Add sample for ScreenShot
_Update the ScreenShot methods
_Add the doctumentation type;
_Add ScreenOutputType
@msftclas
Copy link
Copy Markdown

msftclas commented Sep 16, 2018

CLA assistant check
All CLA requirements met.

@dend
Copy link
Copy Markdown
Contributor

dend commented Sep 16, 2018

❌ Validation status: errors

File Status Preview URL Details
❌Error Details

  • [Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/xamarin/Essentials, working directory: W:\oxsh-s, target branch: master, target branch commit: 5def00a, source branch: 5615ed2830a74f8f7aa8edcb6802e854/master, source branch commit: .

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Copy Markdown
Contributor

dend commented Sep 16, 2018

❌ Validation status: errors

File Status Preview URL Details
❌Error Details
❌Error Details

  • [Error] Failed to load 1 files, aborting...
  • [Error] System.IO.FileNotFoundException: File not found.
    File name: 'W:\q2ea-log-a6046d0a\change-list-with-redirection.mapped.tsv'
    at Microsoft.DocAsCode.Build.Engine.Incrementals.ChangeList.Parse(String tsvFile, String baseDir)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()
  • Line 80: [Warning] Failed to run script W:\q2ea-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

  • [Error] Failed to load 1 files, aborting...
  • [Error] System.IO.FileNotFoundException: File not found.
    File name: 'W:\q2ea-log-a6046d0a\change-list-with-redirection.mapped.tsv'
    at Microsoft.DocAsCode.Build.Engine.Incrementals.ChangeList.Parse(String tsvFile, String baseDir)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()
  • Line 80: [Warning] Failed to run script W:\q2ea-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Copy Markdown
Contributor

dend commented Sep 16, 2018

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details

  • Line 80: [Warning] Failed to run script W:\srou-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Copy Markdown
Contributor

dend commented Sep 20, 2018

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details

  • Line 80: [Warning] Failed to run script W:\fqcg-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented Oct 1, 2018

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details

  • Line 80: [Warning] Failed to run script W:\12f2-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented Oct 1, 2018

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details

  • Line 80: [Warning] Failed to run script W:\mzbf-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@pictos pictos closed this Oct 5, 2018
@pictos pictos mentioned this pull request Nov 27, 2018
@mattleibow mattleibow mentioned this pull request Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants