Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Fixed #776 to handle VMs of UWP#787

Merged
jamesmontemagno merged 3 commits intomasterfrom
bug/issue-776
May 30, 2019
Merged

Fixed #776 to handle VMs of UWP#787
jamesmontemagno merged 3 commits intomasterfrom
bug/issue-776

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

@jamesmontemagno jamesmontemagno commented May 16, 2019

Description of Change

Describe your changes here.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

Behavioral Changes

Now will return virtual for any VM scenario.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label May 16, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 16, 2019

Docs Build status updates of commit cbf3eed:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/DeviceInfo/DeviceInfo.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone May 17, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 17, 2019

Docs Build status updates of commit b7865c1:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/DeviceInfo/DeviceInfo.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

newky2k
newky2k approved these changes May 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@newky2k newky2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have build and run the code locally and it all works OK

@newky2k newky2k added ready-to-merge Review completed, Ready for API review and merge and removed awaiting-review This PR needs to have a set of eyes on it labels May 29, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 29, 2019

Docs Build status updates of commit adb159c:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/DeviceInfo/DeviceInfo.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno merged commit 8e9973a into master May 30, 2019
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
@jamesmontemagno
Fixed xamarin#776 to handle VMs (xamarin#787)
fa3471d
@jamesmontemagno jamesmontemagno deleted the bug/issue-776 branch December 20, 2019 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mattleibow mattleibow mattleibow approved these changes

@newky2k newky2k newky2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesmontemagno @mattleibow @newky2k