Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.
This repository was archived by the owner on May 15, 2024. It is now read-only.

SecureStorage.android.cs: PlatformRemove(key) returns wrong value #771

@joduss

Description

@joduss

The method Remove(key: String) is supposed to return true if the key-value pair is removed, as stated in the documentation. But for the android implementaiton, it always returns false.

By looking at the code, the problem is clear. The return value is hard coded to be always false.

        static bool PlatformRemove(string key)
        {
            var context = Platform.AppContext;

            key = Utils.Md5Hash(key);
            Preferences.Remove(key, Alias);

            return false;
        }

I have located when the bug was first introduced in the commit: 4da4ea3.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions