Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Add more null checks in LocationAuthCallback Should Fix #740#748

Merged
jamesmontemagno merged 7 commits intomasterfrom
dev/gh-740
May 31, 2019
Merged

Add more null checks in LocationAuthCallback Should Fix #740#748
jamesmontemagno merged 7 commits intomasterfrom
dev/gh-740

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

Description of Change

Just doing some more null checks on auth callbacks. Shouldn't happen, but let's check for them :)

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

None

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno changed the title Add mroe null checks in LocationAuthCallback Should Fix #740 Add more null checks in LocationAuthCallback Should Fix #740 Mar 26, 2019
@jamesmontemagno jamesmontemagno added this to the v1.1.1 milestone Mar 26, 2019
@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Mar 26, 2019
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2019

OPS Build status updates of commit c491292:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Permissions/Permissions.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented Mar 29, 2019

OPS Build status updates of commit 0507557:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Permissions/Permissions.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@newky2k newky2k self-requested a review May 28, 2019 17:55
@ghost
Copy link
Copy Markdown

ghost commented May 28, 2019

Docs Build status updates of commit 5cfe9a1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
.openpublishing.publish.config.json ❌Error Details

  • Line 117: [Error] Restore nuget package W:\memc-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\memc-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects Unable to find version '1.0.483' of package 'Microsoft.DocAsCode.ECMA2Yaml'. D:\Windows\system32\config\systemprofile\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'D:\Windows\system32\config\systemprofile\.nuget\packages\'. https://www.myget.org/F/op/api/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'https://www.myget.org/F/op/api/v2'.

.openpublishing.publish.config.json

  • Line 290: [Error] Restore of dependent packages failed. Please check your .openpublishing.publish.config.json?on the configuration of the dependent packages or ask for help?in Docs Support teams channel. Please also include the following error code for our team to troubleshoot: 1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@newky2k newky2k added the in-progress Actively being worked on. label May 28, 2019
@newky2k newky2k added ready-to-merge Review completed, Ready for API review and merge and removed in-progress Actively being worked on. awaiting-review This PR needs to have a set of eyes on it labels May 28, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 29, 2019

Docs Build status updates of commit 79bdfc8:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Permissions/Permissions.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 30, 2019

Docs Build status updates of commit bf6f594:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Permissions/Permissions.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 30, 2019

Docs Build status updates of commit 4ee2107:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Permissions/Permissions.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Docs Build status updates of commit 94b904e:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Permissions/Permissions.ios.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno merged commit 5b4cf54 into master May 31, 2019
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
@mattleibow mattleibow deleted the dev/gh-740 branch November 8, 2019 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants