This repository was archived by the owner on May 15, 2024. It is now read-only.
Check for null MainView on UWP#803
Merged
jamesmontemagno merged 2 commits intomasterfrom May 31, 2019
Merged
Conversation
|
Docs Build status updates of commit 459ec7b: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
2 tasks
|
Docs Build status updates of commit 06f4e59: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
newky2k
approved these changes
May 31, 2019
Contributor
newky2k
left a comment
There was a problem hiding this comment.
Review, build and tested
Mrnikbobjeff
pushed a commit
to Mrnikbobjeff/Essentials
that referenced
this pull request
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Additional null checks on main window if called at the start of an app.
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
List all API changes here (or just put None), example:
Added:
string Class.Property { get; set; }void Class.Method();Changed:
object Cell.OldPropertyName=>object Cell.NewPropertyNameIf there is an entirely new API, then you can use a more verbose style:
Behavioral Changes
Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.
PR Checklist