Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Fixes #771 - Add test for remove SS and fix android return value#772

Merged
jamesmontemagno merged 3 commits intomasterfrom
dev/gh-771
May 30, 2019
Merged

Fixes #771 - Add test for remove SS and fix android return value#772
jamesmontemagno merged 3 commits intomasterfrom
dev/gh-771

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

@jamesmontemagno jamesmontemagno commented Apr 27, 2019

Description of Change

Describe your changes here.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

None

Behavioral Changes

Will return true now when we remove the key from android

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno requested a review from Redth April 27, 2019 18:54
@ghost
Copy link
Copy Markdown

ghost commented Apr 27, 2019

Docs Build status updates of commit 52aeb7d:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/SecureStorage_Tests.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone Apr 27, 2019
@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Apr 27, 2019
@newky2k newky2k added awaiting-review This PR needs to have a set of eyes on it ready-to-merge Review completed, Ready for API review and merge and removed awaiting-review This PR needs to have a set of eyes on it labels May 29, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 29, 2019

Docs Build status updates of commit ddfd647:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/SecureStorage_Tests.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 30, 2019

Docs Build status updates of commit 37190cf:

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Shared/SecureStorage_Tests.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno merged commit 8153a82 into master May 30, 2019
@jamesmontemagno jamesmontemagno deleted the dev/gh-771 branch May 30, 2019 23:00
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
@jamesmontemagno
Fixes xamarin#771 - Add test for remove SS and fix android return val…
d9664ab 
…ue (xamarin#772)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Redth Redth Awaiting requested review from Redth

1 more reviewer

@mattleibow mattleibow mattleibow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Review completed, Ready for API review and merge

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesmontemagno @mattleibow @newky2k