This repository was archived by the owner on May 15, 2024. It is now read-only.
Merged
Conversation
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md In doing some performance testing with builds in VS 2019, I noticed: 115 ms _ConvertPdbFiles 1 calls And looking at files were converted: ConvertDebuggingFiles Parameters Files C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.pdb [Output] ConvertedFiles: C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.dll The Xamarin.Essentials NuGet package is shipping a non-portable PDB file. This is a Windows-specific format that Mono doesn't support. Xamarin.Android runs a tool called `pdb2mdb` when it encounters a non-portable PDB file so symbols be converted to something that Mono can use. If you have `DebugType=full` or `DebugType=pdbonly`, Xamarin.Android has to do this extra work to convert it. I see no drawbacks to just use `DebugType=portable` in this project all the time? Since Xamarin.Essentials uses sourcelink, I double-checked and they support portable PDBs: https://github.com/dotnet/sourcelink#prerequisites-for-net-projects I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a bit more detail on symbol files there if you need more info: xamarin/Xamarin.Forms#4201
|
Docs Build status updates of commit 2962481: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
mattleibow
approved these changes
Apr 4, 2019
Mrnikbobjeff
pushed a commit
to Mrnikbobjeff/Essentials
that referenced
this pull request
Aug 28, 2019
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md In doing some performance testing with builds in VS 2019, I noticed: 115 ms _ConvertPdbFiles 1 calls And looking at files were converted: ConvertDebuggingFiles Parameters Files C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.pdb [Output] ConvertedFiles: C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.dll The Xamarin.Essentials NuGet package is shipping a non-portable PDB file. This is a Windows-specific format that Mono doesn't support. Xamarin.Android runs a tool called `pdb2mdb` when it encounters a non-portable PDB file so symbols be converted to something that Mono can use. If you have `DebugType=full` or `DebugType=pdbonly`, Xamarin.Android has to do this extra work to convert it. I see no drawbacks to just use `DebugType=portable` in this project all the time? Since Xamarin.Essentials uses sourcelink, I double-checked and they support portable PDBs: https://github.com/dotnet/sourcelink#prerequisites-for-net-projects I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a bit more detail on symbol files there if you need more info: xamarin/Xamarin.Forms#4201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md
In doing some performance testing with builds in VS 2019, I noticed:
And looking at files were converted:
The Xamarin.Essentials NuGet package is shipping a non-portable PDB
file. This is a Windows-specific format that Mono doesn't support.
Xamarin.Android runs a tool called
pdb2mdbwhen it encounters anon-portable PDB file so symbols be converted to something that Mono
can use. If you have
DebugType=fullorDebugType=pdbonly,Xamarin.Android has to do this extra work to convert it.
I see no drawbacks to just use
DebugType=portablein this projectall the time?
Since Xamarin.Essentials uses sourcelink, I double-checked and they
support portable PDBs:
https://github.com/dotnet/sourcelink#prerequisites-for-net-projects
I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a
bit more detail on symbol files there if you need more info:
xamarin/Xamarin.Forms#4201
Bugs Fixed
None filed, I just saw this when doing perf work with VS 2019.
API Changes
n/a
Behavioral Changes
Initial build times should improve by ~100ms.
PR Checklist