Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

GH-800: Fix Multi-attachment on Android emails#804

Merged
jamesmontemagno merged 4 commits intomasterfrom
bug/gh-800
Jun 3, 2019
Merged

GH-800: Fix Multi-attachment on Android emails#804
jamesmontemagno merged 4 commits intomasterfrom
bug/gh-800

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

@jamesmontemagno jamesmontemagno commented May 30, 2019

Description of Change

Have to use a different intent for multiple attachments :(

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

none.

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone May 30, 2019
@jamesmontemagno jamesmontemagno mentioned this pull request May 30, 2019
Closed
@ghost
Copy link
Copy Markdown

ghost commented May 30, 2019

Docs Build status updates of commit 1bf2279:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/EmailPage.xaml ✅Succeeded
Samples/Samples/ViewModel/EmailViewModel.cs ✅Succeeded
Xamarin.Essentials/Email/Email.android.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label May 30, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Docs Build status updates of commit caf0abf:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/EmailPage.xaml ✅Succeeded
Samples/Samples/ViewModel/EmailViewModel.cs ✅Succeeded
Xamarin.Essentials/Email/Email.android.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

mattleibow
mattleibow approved these changes May 31, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Not tested.

@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Docs Build status updates of commit 0dc95b8:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/EmailPage.xaml ✅Succeeded
Samples/Samples/ViewModel/EmailViewModel.cs ✅Succeeded
Xamarin.Essentials/Email/Email.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno merged commit e452d95 into master Jun 3, 2019
@jamesmontemagno jamesmontemagno deleted the bug/gh-800 branch June 3, 2019 15:10
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
@jamesmontemagno
xamarinGH-800: Fix Multi-attachment on Android emails (xamarin#804)
bbe0b3c 
* Check for null MainView

* Use the ActionSendMultiple on android for multi-attachments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Redth Redth Awaiting requested review from Redth

@newky2k newky2k Awaiting requested review from newky2k

1 more reviewer

@mattleibow mattleibow mattleibow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesmontemagno @mattleibow