Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Fixes #786, set the speach rate to 1 always. (Android)#796

Merged
jamesmontemagno merged 5 commits intomasterfrom
bug/issue-gh-786
Jun 3, 2019
Merged

Fixes #786, set the speach rate to 1 always. (Android)#796
jamesmontemagno merged 5 commits intomasterfrom
bug/issue-gh-786

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

Description of Change

Always use one else may get mixed results on different devices :(

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

None

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno requested a review from Redth May 22, 2019 22:26
@ghost
Copy link
Copy Markdown

ghost commented May 22, 2019

Docs Build status updates of commit fa18aa0:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mattleibow mattleibow closed this May 24, 2019
@mattleibow mattleibow reopened this May 24, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 24, 2019

Docs Build status updates of commit fa18aa0:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
.openpublishing.publish.config.json ❌Error Details

  • Line 117: [Error] Restore nuget package W:\hp50-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\hp50-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects Unable to find version '1.0.483' of package 'Microsoft.DocAsCode.ECMA2Yaml'. D:\Windows\system32\config\systemprofile\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'D:\Windows\system32\config\systemprofile\.nuget\packages\'. https://www.myget.org/F/op/api/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'https://www.myget.org/F/op/api/v2'.

.openpublishing.publish.config.json

  • Line 290: [Error] Restore of dependent packages failed. Please check your .openpublishing.publish.config.json?on the configuration of the dependent packages or ask for help?in Docs Support teams channel. Please also include the following error code for our team to troubleshoot: 1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@conceptdev
Copy link
Copy Markdown
Contributor

Closing and re-opening this PR on advice from docs team, to fix build validation error.

@conceptdev conceptdev closed this May 28, 2019
@conceptdev conceptdev reopened this May 28, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 28, 2019

Docs Build status updates of commit fa18aa0:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
.openpublishing.publish.config.json ❌Error Details

  • Line 117: [Error] Restore nuget package W:\4nft-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\4nft-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects Unable to find version '1.0.483' of package 'Microsoft.DocAsCode.ECMA2Yaml'. D:\Windows\system32\config\systemprofile\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'D:\Windows\system32\config\systemprofile\.nuget\packages\'. https://www.myget.org/F/op/api/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'https://www.myget.org/F/op/api/v2'.

.openpublishing.publish.config.json

  • Line 290: [Error] Restore of dependent packages failed. Please check your .openpublishing.publish.config.json?on the configuration of the dependent packages or ask for help?in Docs Support teams channel. Please also include the following error code for our team to troubleshoot: 1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@conceptdev conceptdev closed this May 28, 2019
@conceptdev conceptdev reopened this May 28, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 28, 2019

Docs Build status updates of commit fa18aa0:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label May 29, 2019
@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone May 29, 2019
@ghost
Copy link
Copy Markdown

ghost commented May 29, 2019

Docs Build status updates of commit 7d7b38a:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Docs Build status updates of commit 0684e0c:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Copy Markdown
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if Android decides that 0.5 is normal speed and 1 is the fastest? Sort of a 0=slowest;1=fastest.

What is the scale on Android?

@ghost
Copy link
Copy Markdown

ghost commented Jun 3, 2019

Docs Build status updates of commit 7e00192:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link
Copy Markdown

ghost commented Jun 3, 2019

Docs Build status updates of commit 7b265d4:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno merged commit ac795bc into master Jun 3, 2019
@jamesmontemagno jamesmontemagno deleted the bug/issue-gh-786 branch June 3, 2019 16:15
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants