Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

searcher: remove unused diff.ParseGitDiffNameStatus package#62363

Merged
ggilmore merged 1 commit into
mainfrom
05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package
May 7, 2024
Merged

searcher: remove unused diff.ParseGitDiffNameStatus package#62363
ggilmore merged 1 commit into
mainfrom
05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package

Conversation

@ggilmore

@ggilmore ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This package no longer has any users since the introduction of
https://github.com/sourcegraph/sourcegraph/pull/62354.

Let's remove it!

Test plan

CI

@cla-bot cla-bot Bot added the cla-signed label May 1, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 1, 2024
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore marked this pull request as ready for review May 1, 2024 22:09
@ggilmore ggilmore requested review from a team May 1, 2024 22:09
eseliger
eseliger approved these changes May 1, 2024
View reviewed changes

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a single test to remove :( that's good though, less untested code!

@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

Ad gif. Man with a beard and a plaid button up shirt stands next to a rocky river in the wilderness. He looks at us with a smug smile, holding a Busch beer in one hand, giving a big thumbs up with the other. (Added via Giphy)

@graphite-app

graphite-app Bot commented May 2, 2024 •
edited
Loading

Copy link
Copy Markdown

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (05/02/24)

1 gif was posted to this PR based on Geoffrey Gilmore's automation.

"Auto-assign PRs to author" took an action on this PR • (05/02/24)

3 assignees were added to this PR based on Geoffrey Gilmore's automation.

@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 9184f90 to 3e52a4f Compare May 2, 2024 17:44
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 41f32e8 to e20d5f0 Compare May 2, 2024 17:44
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 3e52a4f to 0c91dca Compare May 2, 2024 17:46
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from e20d5f0 to 6a6f1f9 Compare May 2, 2024 17:46
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 45dc812 to f5a0d07 Compare May 6, 2024 18:58
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 7bbdf53 to 16f1143 Compare May 6, 2024 18:58
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from f5a0d07 to 503c409 Compare May 6, 2024 18:59
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 16f1143 to 95bb926 Compare May 6, 2024 18:59
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 503c409 to 12e962d Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 95bb926 to 4bffc47 Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 12e962d to 1a3a387 Compare May 6, 2024 19:15
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 4bffc47 to 1c1337a Compare May 6, 2024 19:15
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 1a3a387 to 5fbe0c4 Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 1c1337a to 9039cef Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 5fbe0c4 to 6d60e25 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 9039cef to 610f29c Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 6d60e25 to e1a3be0 Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 610f29c to d1fecb1 Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from e1a3be0 to 470d785 Compare May 6, 2024 21:56
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from d1fecb1 to 14758c9 Compare May 6, 2024 21:56
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 470d785 to fedae8e Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 14758c9 to 4831ea3 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from fedae8e to 3895516 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 4831ea3 to fb84487 Compare May 6, 2024 23:36
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 3895516 to ee069a0 Compare May 6, 2024 23:51
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from fb84487 to 6020015 Compare May 6, 2024 23:51
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from ee069a0 to 83da99f Compare May 7, 2024 03:48
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 6020015 to 1f91cd1 Compare May 7, 2024 03:48
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 83da99f to 039b580 Compare May 7, 2024 16:14
@ggilmore ggilmore force-pushed the 05-01-searcher_remove_unsued_diff.parsegitdiffnamestatus_package branch from 1f91cd1 to b18a458 Compare May 7, 2024 16:14
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 039b580 to c5499b6 Compare May 7, 2024 16:16
@ggilmore Graphite App

ggilmore commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 7, 2:51 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 3:01 PM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pjlast pjlast

@ggilmore ggilmore

@eseliger eseliger

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ggilmore @keegancsmith @eseliger @pjlast