Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

worker: embeddings: replace usage of old gitserver.DiffSymbols client method with new gitserver.ChangedFiles method#62359

Merged
ggilmore merged 1 commit into
mainfrom
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
May 7, 2024
Merged

worker: embeddings: replace usage of old gitserver.DiffSymbols client method with new gitserver.ChangedFiles method#62359
ggilmore merged 1 commit into
mainfrom
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method

Conversation

@ggilmore

@ggilmore ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of https://github.com/sourcegraph/sourcegraph/issues/60654

This PR replaces the worker embedding job's use of the old gitserver.DiffSymbols endpoint with the gitserver.ChangedFiles gRPC endpoint introduced in #62354.

Test plan

Existing CI

@cla-bot cla-bot Bot added the cla-signed label May 1, 2024
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 1, 2024
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from aef2100 to a65df71 Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from a0b217e to 85029be Compare May 1, 2024 21:13
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from a65df71 to 37153ff Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 85029be to 69e4bb9 Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 37153ff to eb2fbee Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 69e4bb9 to aaf73ae Compare May 1, 2024 21:22
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from eb2fbee to 6ad30aa Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from aaf73ae to 2c110b4 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 6ad30aa to 944d98c Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 2c110b4 to 3d38d96 Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 944d98c to 47c96dc Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 3d38d96 to 253343d Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from ab52e41 to 3e710d7 Compare May 3, 2024 22:03
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d17af74 to d478afe Compare May 3, 2024 22:03
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 3e710d7 to f7b9c58 Compare May 3, 2024 22:14
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d478afe to d9f5193 Compare May 3, 2024 22:14
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from f7b9c58 to 191ca5d Compare May 3, 2024 22:38
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d9f5193 to b9c88af Compare May 3, 2024 22:38
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 191ca5d to 6ea78a8 Compare May 6, 2024 16:44
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from b9c88af to 852db8c Compare May 6, 2024 16:44
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 6ea78a8 to d178e40 Compare May 6, 2024 16:48
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 852db8c to a43d199 Compare May 6, 2024 16:48
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from d178e40 to acce517 Compare May 6, 2024 17:02
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from a43d199 to 84cd7c1 Compare May 6, 2024 17:02
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from acce517 to 0c94ae9 Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 84cd7c1 to 573101a Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 0c94ae9 to 4ae4099 Compare May 6, 2024 18:55
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch 2 times, most recently from c84e051 to d069eab Compare May 6, 2024 18:58
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 4ae4099 to dc5ff89 Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d069eab to 7e43590 Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from dc5ff89 to 93fb55b Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 7e43590 to f63624e Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 93fb55b to 1327c66 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from f63624e to 93a4bc2 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 1327c66 to 69edd2b Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 93a4bc2 to ffed11d Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 69edd2b to 54d0a0b Compare May 6, 2024 21:56
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from ffed11d to a57255b Compare May 6, 2024 21:56
@ggilmore
worker: embeddings: replace usage of old gitserver.DiffSymbols client…
c2000a7 
… method with new gitserver.ChangedFiles method
@ggilmore Graphite App

ggilmore commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 7, 2:22 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 2:33 PM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pjlast pjlast

@ggilmore ggilmore

@eseliger eseliger

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ggilmore @keegancsmith @eseliger @pjlast