Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit#62173

Merged
ggilmore merged 2 commits into
mainfrom
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
May 1, 2024
Merged

gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit#62173
ggilmore merged 2 commits into
mainfrom
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit

Conversation

@ggilmore

@ggilmore ggilmore commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes https://github.com/sourcegraph/sourcegraph/issues/61689

This PR switches the gitserver client implementation to use the new gRPC FirstCommitEver() method introduced in https://github.com/sourcegraph/sourcegraph/pull/62169 instead of shoving it through the exec() endpoint.

Test plan

Unit tests

@cla-bot cla-bot Bot added the cla-signed label Apr 24, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore requested a review from a team April 24, 2024 22:20
@ggilmore ggilmore changed the title gitserver: grpc: switch clientImplementor to use gRPC for FirstEverCommit Pull Request Summary Apr 24, 2024
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 22:21
@ggilmore ggilmore changed the title Pull Request Summary gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit Apr 24, 2024
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 1340dfb to f6b6171 Compare April 25, 2024 19:08
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9ef85ef to 8ff0aa1 Compare April 25, 2024 19:09
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f6b6171 to f858a22 Compare April 25, 2024 19:12
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 8ff0aa1 to 7f16541 Compare April 25, 2024 19:12
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f858a22 to 02ec89e Compare April 25, 2024 19:28
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 7f16541 to 982582a Compare April 25, 2024 19:28
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 02ec89e to 5c223e4 Compare April 25, 2024 19:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 982582a to 75c9be3 Compare April 25, 2024 19:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 5c223e4 to 1f012eb Compare April 25, 2024 23:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 75c9be3 to 9bb6fe5 Compare April 25, 2024 23:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 1f012eb to 9f0a175 Compare April 25, 2024 23:16
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9bb6fe5 to 9b5b1b7 Compare April 25, 2024 23:16
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 9f0a175 to 582385f Compare April 26, 2024 17:20
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9b5b1b7 to 89f6149 Compare April 26, 2024 17:20
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 582385f to 6c0168e Compare April 26, 2024 18:59
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 89f6149 to 4c62a2d Compare April 26, 2024 18:59
@ggilmore ggilmore mentioned this pull request Apr 26, 2024
Merged
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9e83fa2 to 5848e61 Compare April 30, 2024 05:19
eseliger
eseliger approved these changes Apr 30, 2024
View reviewed changes
Comment thread internal/insights/gitserver/first_commit.go Outdated
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 6543606 to f258a65 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch 2 times, most recently from e3f21ba to 1cbf637 Compare April 30, 2024 17:14
@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f258a65 to f5c873d Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 1cbf637 to b52e1ec Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f5c873d to 07f51e6 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from b52e1ec to 99c6668 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 07f51e6 to 9c9c844 Compare April 30, 2024 20:06
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 6de4b91 to d3bef7f Compare April 30, 2024 20:07
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 9c9c844 to 302550c Compare April 30, 2024 20:34
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from d3bef7f to 0d07353 Compare April 30, 2024 20:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 302550c to 241022e Compare April 30, 2024 22:29
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 0d07353 to bfbeb0f Compare April 30, 2024 22:30
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 241022e to c4f47bf Compare May 1, 2024 04:16
Base automatically changed from 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation to main May 1, 2024 04:32
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from bfbeb0f to df8113e Compare May 1, 2024 04:34
@ggilmore Graphite App

ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 1, 12:35 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 1, 12:46 AM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit b1b0595 into main May 1, 2024
@ggilmore ggilmore deleted the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch May 1, 2024 04:46
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@eseliger eseliger eseliger approved these changes

@pjlast pjlast pjlast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gitserver: Move FirstEverCommit to new gRPC pattern

3 participants

@ggilmore @pjlast @eseliger