This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: grpc: add new ChangedFiles method to gitserver client#62354
Merged
ggilmore merged 1 commit intoMay 7, 2024
Merged
Conversation
This was referenced May 1, 2024
Contributor
Author
This was referenced May 1, 2024
Merged
d5d0cc7 to
fc07518
Compare
27bd9cc to
eaac69f
Compare
fc07518 to
afd8bee
Compare
eaac69f to
337f48e
Compare
afd8bee to
977b125
Compare
337f48e to
4da9e89
Compare
977b125 to
eac84a7
Compare
4da9e89 to
a5d3f66
Compare
eac84a7 to
f6dd6ff
Compare
a5d3f66 to
a6d5687
Compare
8b3d845 to
e490d50
Compare
153c146 to
17573de
Compare
e490d50 to
804cbdd
Compare
17573de to
0af92c9
Compare
Contributor
Author
|
@sourcegraph/source Can you please take another look at this PR (and all the upstack PRs that use it)? I refactored the approach here to use iterators. |
eseliger
approved these changes
May 6, 2024
804cbdd to
7a61aa2
Compare
0af92c9 to
6eb1d2f
Compare
7a61aa2 to
6248ab5
Compare
cb06748 to
9c74216
Compare
6248ab5 to
b8070d0
Compare
9c74216 to
aa9ed29
Compare
b8070d0 to
85a0105
Compare
41f212e to
5f646f0
Compare
85a0105 to
fbb2877
Compare
5f646f0 to
1bb89ac
Compare
fbb2877 to
53c8d36
Compare
Base automatically changed from
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
to
main
May 7, 2024 17:43
1bb89ac to
a54db0c
Compare
Contributor
Author
ggilmore
referenced
this pull request
May 7, 2024
…new ChangedFiles method (#62355) Part of https://github.com/sourcegraph/sourcegraph/issues/60654 This PR builds on the new ChangedFiles method introduced in https://github.com/sourcegraph/sourcegraph/pull/62354, and changes the symbols service to use it instead of the old custom diff symbols method. ## Test plan Existing CI pipeline
ggilmore
referenced
this pull request
May 7, 2024
…hangedFiles client method (#62358) Part of https://github.com/sourcegraph/sourcegraph/issues/60654 This PR replaces hybrid's search use of the gitserver.DiffSymbols endpoint with the new gitserver.ChangedFiles gRPC endpoint introduced in https://github.com/sourcegraph/sourcegraph/pull/62354. ## Test plan Existing CI pipeline
ggilmore
added a commit
that referenced
this pull request
May 7, 2024
… method with new gitserver.ChangedFiles method (#62359) Part of https://github.com/sourcegraph/sourcegraph/issues/60654 This PR replaces the worker embedding job's use of the old gitserver.DiffSymbols endpoint with the gitserver.ChangedFiles gRPC endpoint introduced in #62354. ## Test plan Existing CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/sourcegraph/sourcegraph/issues/60654
This PR builds on https://github.com/sourcegraph/sourcegraph/pull/62216, and creates a new ChangedFiles method in the gitserver client that calls the new gRPC method that was introduced in https://github.com/sourcegraph/sourcegraph/pull/62216.
Note: This PR doesn't change / remove any existing callers of DiffSymbols. I made those changes in future stacked PRs to ensure that they're easy to review.
Test plan
New Unit tests