Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: create server implementation for GetBehindAhead#62216

Merged
ggilmore merged 4 commits into
mainfrom
04-26-gitserver_grpc_create_server_implementation_for_getbehindahead
May 3, 2024
Merged

gitserver: grpc: create server implementation for GetBehindAhead#62216
ggilmore merged 4 commits into
mainfrom
04-26-gitserver_grpc_create_server_implementation_for_getbehindahead

Conversation

@ggilmore

@ggilmore ggilmore commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of https://github.com/sourcegraph/sourcegraph/issues/62101

This PR implements the server-side gRPC implementation of GetBehindAhead, and hooks it up to the new git Backend implementation from #62212.

Test plan

Unit tests

@cla-bot cla-bot Bot added the cla-signed label Apr 26, 2024
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 26, 2024
@ggilmore ggilmore mentioned this pull request Apr 26, 2024
Merged
@ggilmore ggilmore marked this pull request as ready for review April 26, 2024 21:10
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from e20d95c to 5b77abc Compare April 26, 2024 21:13
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 75c2c85 to 5a836f7 Compare April 26, 2024 21:13
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from 5b77abc to a20dd1b Compare April 26, 2024 21:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 5a836f7 to 7fa75c2 Compare April 26, 2024 21:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from a20dd1b to 85215bf Compare April 29, 2024 19:20
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 7fa75c2 to 811c697 Compare April 29, 2024 19:24
@ggilmore ggilmore mentioned this pull request Apr 29, 2024
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from 85215bf to ec4200b Compare April 30, 2024 05:16
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 811c697 to 33260ee Compare April 30, 2024 05:16
@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from ec4200b to 9cff9f2 Compare April 30, 2024 05:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 33260ee to 9ce3bb2 Compare April 30, 2024 05:19
eseliger
eseliger approved these changes Apr 30, 2024
View reviewed changes
Comment thread internal/gitserver/v1/gitserver.proto Outdated
Comment thread internal/gitserver/v1/gitserver.proto Outdated
Comment thread internal/gitserver/v1/gitserver.proto Outdated
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from 9cff9f2 to e70c2b0 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 9ce3bb2 to 50df291 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from e70c2b0 to 2cc3609 Compare April 30, 2024 17:14
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 50df291 to a780150 Compare April 30, 2024 17:14
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from 2cc3609 to 15bb244 Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from a780150 to 48d352b Compare April 30, 2024 18:06
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from b5170ef to 6339643 Compare May 1, 2024 21:12
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 01c8dae to 6b57f46 Compare May 1, 2024 21:12
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch 2 times, most recently from 3e9b113 to 0102189 Compare May 1, 2024 21:25
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
eseliger
eseliger approved these changes May 1, 2024
View reviewed changes

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending two small things, see inline comments

Comment thread cmd/gitserver/internal/server_grpc.go Outdated
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

Cartoon gif. A smiling, wide-eyed Chicken Bro big teeth gives us a thumbs up and nods. (Added via Giphy)

@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (05/02/24)

1 gif was posted to this PR based on Geoffrey Gilmore's automation.

@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from 3c51a0a to 16b66bb Compare May 2, 2024 17:43
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch 2 times, most recently from da929c9 to 33edcd2 Compare May 2, 2024 17:45
ggilmore
ggilmore commented May 2, 2024
View reviewed changes
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend branch from 16b66bb to e036062 Compare May 2, 2024 18:04
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch 2 times, most recently from b43579c to 429025c Compare May 2, 2024 18:23
Base automatically changed from 04-26-gitserver_grpc_port_getbehindahead_from_client_to_gitcli_backend to main May 2, 2024 18:25
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 429025c to 11f62c4 Compare May 2, 2024 18:26
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 11f62c4 to aa22c02 Compare May 3, 2024 16:48
@ggilmore ggilmore merged commit a07a3ae into main May 3, 2024
@ggilmore Graphite App

ggilmore commented May 3, 2024

Copy link
Copy Markdown
Contributor Author

Merge activity

@ggilmore ggilmore deleted the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch May 3, 2024 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger