Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: create changed files RPC implementation for gRPC server#62262

Merged
ggilmore merged 1 commit into
mainfrom
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
May 7, 2024
Merged

gitserver: grpc: create changed files RPC implementation for gRPC server#62262
ggilmore merged 1 commit into
mainfrom
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server

Conversation

@ggilmore

@ggilmore ggilmore commented Apr 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of https://github.com/sourcegraph/sourcegraph/issues/60654

This PR implements a new gitserver gRPC method, ChangedFiles that lists the files that changed between two commits alonside their added/modified/deleted status. This PR builds on the functionality exposed in https://github.com/sourcegraph/sourcegraph/pull/62252.

Test plan

Unit tests

@cla-bot cla-bot Bot added the cla-signed label Apr 30, 2024
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented Apr 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 30, 2024
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 75dd653 to 18d4bba Compare April 30, 2024 05:20
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from f9ac891 to 629d3f0 Compare April 30, 2024 05:20
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 18d4bba to 7a9e364 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 629d3f0 to 952cf93 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 7a9e364 to 319d6a9 Compare April 30, 2024 17:15
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 952cf93 to 8ac1945 Compare April 30, 2024 17:15
@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 319d6a9 to d8cb7fe Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 8ac1945 to d52b616 Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from d8cb7fe to 59cae3e Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from d52b616 to 5a3ca00 Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 59cae3e to 43d8723 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 5a3ca00 to 0fdeabd Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 43d8723 to 9e1c79e Compare April 30, 2024 19:37
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch 2 times, most recently from 008dec5 to e8dc0b0 Compare April 30, 2024 20:05
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 9e1c79e to cf8b5d1 Compare April 30, 2024 20:07
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from e8dc0b0 to 31b2232 Compare April 30, 2024 20:07
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch 2 times, most recently from 1f04ba0 to d5d0cc7 Compare May 1, 2024 20:37
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 1137bf8 to 305509c Compare May 1, 2024 21:12
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from d5d0cc7 to fc07518 Compare May 1, 2024 21:12
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 305509c to 2e3e0ff Compare May 1, 2024 21:17
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from fc07518 to afd8bee Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 2e3e0ff to 71f085f Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from afd8bee to 977b125 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 71f085f to 57d4a5c Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 977b125 to eac84a7 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 57d4a5c to 82e2db3 Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from eac84a7 to f6dd6ff Compare May 1, 2024 21:30
ggilmore
ggilmore commented May 1, 2024
View reviewed changes
Comment thread internal/gitserver/v1/gitserver.proto Outdated
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore changed the title wip: gitserver: grpc: create chagned files impl for grpc server gitserver: grpc: create changed files RPC implementation for gRPC server May 1, 2024
@ggilmore ggilmore marked this pull request as ready for review May 1, 2024 22:11
@ggilmore ggilmore requested a review from a team May 1, 2024 22:11
eseliger
eseliger approved these changes May 1, 2024
View reviewed changes
Comment thread internal/gitserver/v1/gitserver.proto Outdated
Comment thread internal/gitserver/v1/gitserver.proto Outdated
Comment thread internal/gitserver/v1/gitserver.proto Outdated
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
Comment thread cmd/gitserver/internal/server_grpc_test.go Outdated
Comment thread internal/gitserver/gitdomain/log.go Outdated
@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

TV gif. Henry Winkler as The Fonz wears his signature pompadour, leather bomber jacket and aviators, standing next to a young kid also wearing a pompadour, leather bomber jacket and aviators. They both give us a thumbs up. (Added via Giphy)

@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (05/02/24)

1 gif was posted to this PR based on Geoffrey Gilmore's automation.

@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 82e2db3 to 5650c82 Compare May 2, 2024 17:43
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from f6dd6ff to ce9973b Compare May 2, 2024 17:43
@ggilmore Graphite App

ggilmore commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 7, 1:33 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 7, 1:43 PM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger