Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: create exhaustive logger for repository service#62158

Merged
ggilmore merged 1 commit into
mainfrom
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
Apr 24, 2024
Merged

gitserver: grpc: create exhaustive logger for repository service#62158
ggilmore merged 1 commit into
mainfrom
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service

Conversation

@ggilmore

@ggilmore ggilmore commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR builds on https://github.com/sourcegraph/sourcegraph/pull/61270, and adds the request logging funcionality to the repository grpc server in gitserver.

Test plan

Local testing:

Ran env SRC_GITSERVER_EXHAUSTIVE_LOGGING_ENABLED=true SRC_LOG_SCOPE_LEVEL=gitserver.gRPCRequestLogger=debug sg start locally, and saw the following output from the logger in my terminal (note that specifically the repository service is mentioned):

[    gitserver-0] DEBUG gitserver.gRPCRequestLogger internal/server_grpc_logger.go:46 Handled FetchRepository RPC {"server": "gitserver.v1.GitserverRepositoryService", "method": "FetchRepository", "status": "OK", "traceID": "67f1aa837367fa7ea72b164e70a67419", "duration": "1.068438833s", "request": {"repoName": "github.com/sgtest/megarepo"}}

@cla-bot cla-bot Bot added the cla-signed label Apr 24, 2024
@ggilmore Graphite App

ggilmore commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 24, 2024
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 16:56
@ggilmore ggilmore marked this pull request as draft April 24, 2024 16:57
@ggilmore ggilmore mentioned this pull request Apr 24, 2024
Merged
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service branch from 0b26aab to 2443801 Compare April 24, 2024 19:50
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 20:22
@ggilmore ggilmore requested a review from a team April 24, 2024 20:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service branch from 2443801 to 5d7fa42 Compare April 24, 2024 20:24
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service branch from 5d7fa42 to 772f91b Compare April 24, 2024 20:37
This was referenced Apr 24, 2024
Merged
Merged
@ggilmore ggilmore merged commit 8a0b342 into main Apr 24, 2024
@ggilmore ggilmore deleted the 04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service branch April 24, 2024 23:04
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger