Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: remove now unused DiffSymbols func#62360

Merged
ggilmore merged 1 commit into
mainfrom
05-01-gitserver_grpc_remove_now_unused_diffsymbols_func
May 7, 2024
Merged

gitserver: grpc: remove now unused DiffSymbols func#62360
ggilmore merged 1 commit into
mainfrom
05-01-gitserver_grpc_remove_now_unused_diffsymbols_func

Conversation

@ggilmore

@ggilmore ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes https://github.com/sourcegraph/sourcegraph/issues/60654

This PR removes the (now unused) DiffSymbols method from the gitserver client.

Test plan

CI

@cla-bot cla-bot Bot added the cla-signed label May 1, 2024
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 1, 2024
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 85029be to 69e4bb9 Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 9bba630 to 5427583 Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 69e4bb9 to aaf73ae Compare May 1, 2024 21:22
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 5427583 to 45a925d Compare May 1, 2024 21:22
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from aaf73ae to 2c110b4 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 45a925d to b09c7c7 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 2c110b4 to 3d38d96 Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from b09c7c7 to 34f5ee4 Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 3d38d96 to 253343d Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 34f5ee4 to 5ba94db Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 253343d to 20091a7 Compare May 1, 2024 21:59
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 5ba94db to 37fc836 Compare May 1, 2024 21:59
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d478afe to d9f5193 Compare May 3, 2024 22:14
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from bfac7c0 to 95800dd Compare May 3, 2024 22:14
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d9f5193 to b9c88af Compare May 3, 2024 22:38
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 95800dd to b33dbf2 Compare May 3, 2024 22:38
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from b9c88af to 852db8c Compare May 6, 2024 16:44
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from b33dbf2 to 6ce86d9 Compare May 6, 2024 16:44
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 852db8c to a43d199 Compare May 6, 2024 16:48
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 6ce86d9 to 0cae079 Compare May 6, 2024 16:48
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from a43d199 to 84cd7c1 Compare May 6, 2024 17:02
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 0cae079 to 477affa Compare May 6, 2024 17:02
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 84cd7c1 to 573101a Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 477affa to 29d75a1 Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 573101a to c84e051 Compare May 6, 2024 18:55
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 29d75a1 to 45dc812 Compare May 6, 2024 18:56
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from c84e051 to d069eab Compare May 6, 2024 18:58
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch 2 times, most recently from f5a0d07 to 503c409 Compare May 6, 2024 18:59
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from d069eab to 7e43590 Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch 2 times, most recently from 12e962d to 1a3a387 Compare May 6, 2024 19:15
@ggilmore ggilmore requested a review from eseliger May 6, 2024 19:15
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 7e43590 to f63624e Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 1a3a387 to 5fbe0c4 Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from f63624e to 93a4bc2 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_remove_now_unused_diffsymbols_func branch from 5fbe0c4 to 6d60e25 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 93a4bc2 to ffed11d Compare May 6, 2024 19:38
@graphite-app

graphite-app Bot commented May 6, 2024

Copy link
Copy Markdown

TV gif. Timmy from Shaun the Sheep blinks and extends 2 thumbs up as a lopsided grin emerges on the side of his face. (Added via Giphy)

@ggilmore Graphite App

ggilmore commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 7, 2:34 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 7, 2:50 PM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ggilmore ggilmore

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide GQL API to list all files and change mode in a given diff

2 participants

@ggilmore @eseliger