gitserver: grpc: port DiffSymbols from client as new GitBackend.ChangedFiles() func by ggilmore · Pull Request #62252 · sourcegraph/sourcegraph-public-snapshot

ggilmore · 2024-04-29T19:25:03Z

Part of https://github.com/sourcegraph/sourcegraph/issues/61691

This PR adds a new method, ChangedFiles to the git cli backend that lists the files that between the base and head commits, along with their added/modified/deleted status. Unlike the current workflow that involves multiple callsites with their own implementations for parsing the raw gitserver exec output, all the parsing now happens server-side and is well tested.

This functionality should be able to subsume the other diff-tree / diff use-cases in:

Test plan

Added new unit tests:

some that test the E2E output of the git diff-tree command
adapted tests from https://github.com/sourcegraph/sourcegraph/blob/458ce56cf3f8a9756ef25c33a19fb9ca9437dbd3/cmd/symbols/gitserver/client_test.go#L9-L61

ggilmore · 2024-04-29T19:25:14Z

searcher: remove unused diff.ParseGitDiffNameStatus package #62363
gitserver: grpc: remove now unused DiffSymbols func #62360
worker: embeddings: replace usage of old gitserver.DiffSymbols client method with new gitserver.ChangedFiles method #62359
searcher: replace usage of gitserver.DiffSymbols with new gitserver.ChangedFiles client method #62358
symbols: replace usage of gitserver client's DiffSymbols method with new ChangedFiles method #62355
gitserver: grpc: add new ChangedFiles method to gitserver client #62354
gitserver: grpc: create changed files RPC implementation for gRPC server #62262
gitserver: grpc: port DiffSymbols from client as new GitBackend.ChangedFiles() func #62252 👈
gitserver: grpc: swap client implementation of GetAheadBehind from Exec to bespoke gRPC endpoint #62217
gitserver: grpc: create server implementation for GetBehindAhead #62216
gitserver: grpc: port GetBehindAhead from client to gitcli backend #62212
codeinsights: remove now useless empty repo string error check #62302
gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit #62173
gitserver: grpc: create FirstEverCommit RPC method and server implementation #62169
gitserver: port FirstEverCommit functionality from client to git cli backend #62165
gitserver: grpc: create exhaustive logger for repository service #62158
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite

graphite-app · 2024-05-02T15:42:46Z

ggilmore · 2024-05-06T19:16:38Z

@sourcegraph/source Could you please re-review this (and the upstream PRs)? I refactored the approach to use the iterator pattern.

eseliger

LGTM, left a question about using an iterator here as well

eseliger · 2024-05-06T20:14:49Z

The logic in LogReverseEach that we had here: https://github.com/sourcegraph/sourcegraph/pull/62260/files#diff-e7b89c0e3e24a2fda065a7cfa5f06f7b7def4d36189d88e495e5b40f5ca9795fL112-L194 also does some more checks on submodule status and stuff. Not sure if needed here, but might be cool for consolidation. We can do that separately though

…edFiles() func

ggilmore · 2024-05-07T17:32:04Z

Merge activity

May 7, 1:32 PM EDT: @ggilmore merged this pull request with Graphite.

cla-bot Bot added the cla-signed label Apr 29, 2024

ggilmore mentioned this pull request Apr 29, 2024

gitserver: grpc: swap client implementation of GetAheadBehind from Exec to bespoke gRPC endpoint #62217

Merged

github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 29, 2024

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from d02b395 to 39e5cfb Compare April 30, 2024 05:16

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from cc96f91 to 75dd653 Compare April 30, 2024 05:16

ggilmore mentioned this pull request Apr 30, 2024

gitserver: grpc: create changed files RPC implementation for gRPC server #62262

Merged

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 39e5cfb to 3e6f221 Compare April 30, 2024 05:20

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 75dd653 to 18d4bba Compare April 30, 2024 05:20

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 3e6f221 to ca768ec Compare April 30, 2024 17:03

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 18d4bba to 7a9e364 Compare April 30, 2024 17:03

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from ca768ec to dd16782 Compare April 30, 2024 17:14

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 7a9e364 to 319d6a9 Compare April 30, 2024 17:15

ggilmore mentioned this pull request Apr 30, 2024

codeinsights: remove now useless empty repo string error check #62302

Merged

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from dd16782 to 6d618e6 Compare April 30, 2024 18:06

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 319d6a9 to d8cb7fe Compare April 30, 2024 18:06

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 6d618e6 to a450397 Compare April 30, 2024 19:21

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from d8cb7fe to 59cae3e Compare April 30, 2024 19:21

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from a450397 to 48fb88c Compare April 30, 2024 19:22

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 59cae3e to 43d8723 Compare April 30, 2024 19:22

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 48fb88c to 1a44563 Compare April 30, 2024 19:37

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 43d8723 to 9e1c79e Compare April 30, 2024 19:37

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 1a44563 to 8ad5a04 Compare April 30, 2024 20:07

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 666d72e to 1740b89 Compare May 1, 2024 21:12

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 1137bf8 to 305509c Compare May 1, 2024 21:12

ggilmore mentioned this pull request May 1, 2024

gitserver: grpc: remove now unused DiffSymbols func #62360

Merged

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 1740b89 to 15bf6fb Compare May 1, 2024 21:17

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 305509c to 2e3e0ff Compare May 1, 2024 21:17

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 15bf6fb to 9ffa2d5 Compare May 1, 2024 21:21

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 2e3e0ff to 71f085f Compare May 1, 2024 21:21

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 9ffa2d5 to 34cd911 Compare May 1, 2024 21:25

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch 2 times, most recently from 57d4a5c to 82e2db3 Compare May 1, 2024 21:30

ggilmore commented May 1, 2024

View reviewed changes

Comment thread cmd/gitserver/internal/git/gitcli/diff.go Outdated

ggilmore mentioned this pull request May 1, 2024

searcher: remove unused diff.ParseGitDiffNameStatus package #62363

Merged

ggilmore requested a review from a team May 1, 2024 22:11

ggilmore marked this pull request as ready for review May 1, 2024 22:11

eseliger approved these changes May 1, 2024

View reviewed changes

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 34cd911 to b56c84d Compare May 2, 2024 17:43

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 82e2db3 to 5650c82 Compare May 2, 2024 17:43

ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from b56c84d to 0ed26eb Compare May 2, 2024 17:45

ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 5650c82 to f800d7e Compare May 2, 2024 17:45

pjlast reviewed May 6, 2024

View reviewed changes

Comment thread cmd/gitserver/internal/git/gitcli/diff.go Outdated

pjlast approved these changes May 6, 2024

View reviewed changes

eseliger approved these changes May 6, 2024

View reviewed changes

gitserver: grpc: port DiffSymbols from client as new GitBackend.Chang…

1326bb8

…edFiles() func

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gitserver: grpc: port DiffSymbols from client as new GitBackend.ChangedFiles() func#62252

gitserver: grpc: port DiffSymbols from client as new GitBackend.ChangedFiles() func#62252
ggilmore merged 1 commit into
mainfrom
04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func

ggilmore commented Apr 29, 2024 •

edited

Loading

Uh oh!

ggilmore commented Apr 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented May 2, 2024

Uh oh!

Uh oh!

ggilmore commented May 6, 2024

Uh oh!

eseliger left a comment

Uh oh!

eseliger May 6, 2024

Uh oh!

Uh oh!

Uh oh!

ggilmore commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ggilmore commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

ggilmore commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented May 2, 2024

Uh oh!

Uh oh!

ggilmore commented May 6, 2024

Uh oh!

eseliger left a comment

Choose a reason for hiding this comment

Uh oh!

eseliger May 6, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ggilmore commented May 7, 2024

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ggilmore commented Apr 29, 2024 •

edited

Loading

ggilmore commented Apr 29, 2024 •

edited

Loading