Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: create FirstEverCommit RPC method and server implementation#62169

Merged
ggilmore merged 1 commit into
mainfrom
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
May 1, 2024
Merged

gitserver: grpc: create FirstEverCommit RPC method and server implementation#62169
ggilmore merged 1 commit into
mainfrom
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation

Conversation

@ggilmore

@ggilmore ggilmore commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #61689

This PR builds on https://github.com/sourcegraph/sourcegraph/pull/62165, and adds the FirstEverCommit new gRPC method along with a corresponding server implementation. The client implementation will be in a future PR.

Test plan

  • Unit tests

@cla-bot cla-bot Bot added the cla-signed label Apr 24, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 24, 2024
@ggilmore ggilmore mentioned this pull request Apr 24, 2024
Merged
@ggilmore Graphite App

ggilmore commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request Apr 24, 2024
Merged
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 98db01b to 7f3b667 Compare April 24, 2024 21:25
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 21:28
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from cf13ed9 to 26d91b0 Compare April 24, 2024 21:31
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch 7 times, most recently from 2220186 to 1340dfb Compare April 24, 2024 21:46
@ggilmore ggilmore mentioned this pull request Apr 24, 2024
Merged
eseliger
eseliger reviewed Apr 24, 2024
View reviewed changes
Comment thread cmd/gitserver/internal/server_grpc.go Outdated
Comment thread cmd/gitserver/internal/server_grpc_test.go Outdated
Comment thread internal/gitserver/v1/gitserver.proto Outdated
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 26d91b0 to fd32127 Compare April 25, 2024 19:08
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 1340dfb to f6b6171 Compare April 25, 2024 19:09
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from fd32127 to 8e4b04d Compare April 25, 2024 19:12
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch 3 times, most recently from 02ec89e to 5c223e4 Compare April 25, 2024 19:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 8e4b04d to d794dc1 Compare April 25, 2024 23:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch 2 times, most recently from 1f012eb to 9f0a175 Compare April 25, 2024 23:16
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from d794dc1 to 78388ea Compare April 26, 2024 17:20
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 9f0a175 to 582385f Compare April 26, 2024 17:20
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 78388ea to 1bbfc10 Compare April 26, 2024 18:59
@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 05a1f32 to 0dbd2b6 Compare April 30, 2024 05:19
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 467450c to 6543606 Compare April 30, 2024 05:19
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 0dbd2b6 to dd47983 Compare April 30, 2024 17:02
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 6543606 to f258a65 Compare April 30, 2024 17:03
@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from dd47983 to 9504034 Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f258a65 to f5c873d Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 9504034 to cd7c972 Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f5c873d to 07f51e6 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from cd7c972 to 0a3ffb5 Compare April 30, 2024 20:06
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 07f51e6 to 9c9c844 Compare April 30, 2024 20:06
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from 0a3ffb5 to a8d5080 Compare April 30, 2024 20:34
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 9c9c844 to 302550c Compare April 30, 2024 20:34
@ggilmore ggilmore force-pushed the 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend branch from a8d5080 to df87c59 Compare April 30, 2024 22:29
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 302550c to 241022e Compare April 30, 2024 22:29
Base automatically changed from 04-24-gitserver_port_firstevercommit_functionality_from_client_to_git_cli_backend to main May 1, 2024 04:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 241022e to c4f47bf Compare May 1, 2024 04:16
@ggilmore Graphite App

ggilmore commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 1, 12:16 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 1, 12:32 AM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit 5af4aa1 into main May 1, 2024
@ggilmore ggilmore deleted the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch May 1, 2024 04:32
ggilmore referenced this pull request May 1, 2024
@ggilmore
gitserver: grpc: switch clientImplementor to use new dedicated gRPC m…
b1b0595 
…ethod for FirstEverCommit (#62173)

Closes https://github.com/sourcegraph/sourcegraph/issues/61689

This PR switches the gitserver client implementation to use the new gRPC FirstCommitEver() method introduced in https://github.com/sourcegraph/sourcegraph/pull/62169 instead of shoving it through the `exec()` endpoint.

## Test plan

Unit tests
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger