Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

searcher: replace usage of gitserver.DiffSymbols with new gitserver.ChangedFiles client method#62358

Merged
ggilmore merged 1 commit into
mainfrom
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
May 7, 2024
Merged

searcher: replace usage of gitserver.DiffSymbols with new gitserver.ChangedFiles client method#62358
ggilmore merged 1 commit into
mainfrom
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method

Conversation

@ggilmore

@ggilmore ggilmore commented May 1, 2024

Copy link
Copy Markdown
Contributor

Part of https://github.com/sourcegraph/sourcegraph/issues/60654

This PR replaces hybrid's search use of the gitserver.DiffSymbols endpoint with the new gitserver.ChangedFiles gRPC endpoint introduced in https://github.com/sourcegraph/sourcegraph/pull/62354.

Test plan

Existing CI pipeline

ggilmore commented May 1, 2024

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from f51981a to 26416fd Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from aef2100 to a65df71 Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 26416fd to 5de5c61 Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from a65df71 to 37153ff Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 5de5c61 to 7d0bca6 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 37153ff to eb2fbee Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 7d0bca6 to ca030e4 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from eb2fbee to 6ad30aa Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from ca030e4 to d12116b Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 6ad30aa to 944d98c Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from d12116b to f502ebf Compare May 1, 2024 21:52
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 944d98c to 47c96dc Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from f7b9c58 to 191ca5d Compare May 3, 2024 22:38
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 408d801 to 32ff23c Compare May 6, 2024 16:44
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 191ca5d to 6ea78a8 Compare May 6, 2024 16:44
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 32ff23c to a05fbce Compare May 6, 2024 16:48
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch 2 times, most recently from d178e40 to acce517 Compare May 6, 2024 17:02
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from a05fbce to 4eefe29 Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch 2 times, most recently from 0c94ae9 to 4ae4099 Compare May 6, 2024 18:55
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 4eefe29 to df57a3e Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 4ae4099 to dc5ff89 Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from df57a3e to 26e5476 Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from dc5ff89 to 93fb55b Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 26e5476 to 82eb92d Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 93fb55b to 1327c66 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 82eb92d to dbaafc4 Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 1327c66 to 69edd2b Compare May 6, 2024 19:38

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not my area of expertise, but doesn't look completely wrong 😬

@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from dbaafc4 to c500f80 Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 69edd2b to 54d0a0b Compare May 6, 2024 21:56
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from c500f80 to 709a735 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 54d0a0b to 13dde62 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 709a735 to e6c1a79 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 13dde62 to 30c4a53 Compare May 6, 2024 23:35
@keegancsmith

Copy link
Copy Markdown
Member

meta: github does a really bad job with all these graphite updates. The actual review comments all get hidden away with the inconsiquential updates on force-pushes.

ggilmore commented May 7, 2024

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 7, 2:10 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 2:20 PM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants