This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
This was referenced May 1, 2024
Contributor
Author
f51981a to
26416fd
Compare
aef2100 to
a65df71
Compare
26416fd to
5de5c61
Compare
a65df71 to
37153ff
Compare
5de5c61 to
7d0bca6
Compare
37153ff to
eb2fbee
Compare
7d0bca6 to
ca030e4
Compare
eb2fbee to
6ad30aa
Compare
ca030e4 to
d12116b
Compare
6ad30aa to
944d98c
Compare
d12116b to
f502ebf
Compare
944d98c to
47c96dc
Compare
f7b9c58 to
191ca5d
Compare
408d801 to
32ff23c
Compare
191ca5d to
6ea78a8
Compare
32ff23c to
a05fbce
Compare
d178e40 to
acce517
Compare
a05fbce to
4eefe29
Compare
0c94ae9 to
4ae4099
Compare
4eefe29 to
df57a3e
Compare
4ae4099 to
dc5ff89
Compare
df57a3e to
26e5476
Compare
dc5ff89 to
93fb55b
Compare
26e5476 to
82eb92d
Compare
93fb55b to
1327c66
Compare
82eb92d to
dbaafc4
Compare
1327c66 to
69edd2b
Compare
eseliger
approved these changes
May 6, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
not my area of expertise, but doesn't look completely wrong 😬
dbaafc4 to
c500f80
Compare
69edd2b to
54d0a0b
Compare
c500f80 to
709a735
Compare
54d0a0b to
13dde62
Compare
709a735 to
e6c1a79
Compare
13dde62 to
30c4a53
Compare
Member
|
meta: github does a really bad job with all these graphite updates. The actual review comments all get hidden away with the inconsiquential updates on force-pushes. |
…hangedFiles client method
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of https://github.com/sourcegraph/sourcegraph/issues/60654
This PR replaces hybrid's search use of the gitserver.DiffSymbols endpoint with the new gitserver.ChangedFiles gRPC endpoint introduced in https://github.com/sourcegraph/sourcegraph/pull/62354.
Test plan
Existing CI pipeline