Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: swap client implementation of GetAheadBehind from Exec to bespoke gRPC endpoint#62217

Merged
ggilmore merged 1 commit into
mainfrom
04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint
May 3, 2024
Merged

gitserver: grpc: swap client implementation of GetAheadBehind from Exec to bespoke gRPC endpoint#62217
ggilmore merged 1 commit into
mainfrom
04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint

Conversation

@ggilmore

@ggilmore ggilmore commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes https://github.com/sourcegraph/sourcegraph/issues/62101

This PR swaps the gitserver client implemenation of GetBehindAhead to use the new bespoke endpoint introduced in #62216 instead of the all-encompasing exec endpoint.

Test plan

  • Unit tests

This was referenced Apr 26, 2024
Merged
Merged
@cla-bot cla-bot Bot added the cla-signed label Apr 26, 2024
This was referenced Apr 26, 2024
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request Apr 26, 2024
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 26, 2024
@ggilmore ggilmore marked this pull request as ready for review April 26, 2024 21:10
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 75c2c85 to 5a836f7 Compare April 26, 2024 21:13
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch 2 times, most recently from 74aa0a7 to 503a475 Compare April 26, 2024 21:16
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 5a836f7 to 7fa75c2 Compare April 26, 2024 21:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 503a475 to afec55e Compare April 26, 2024 21:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 7fa75c2 to 811c697 Compare April 29, 2024 19:24
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from afec55e to d02b395 Compare April 29, 2024 19:24
@ggilmore ggilmore mentioned this pull request Apr 29, 2024
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 811c697 to 33260ee Compare April 30, 2024 05:16
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from d02b395 to 39e5cfb Compare April 30, 2024 05:16
@ggilmore ggilmore mentioned this pull request Apr 30, 2024
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 33260ee to 9ce3bb2 Compare April 30, 2024 05:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 39e5cfb to 3e6f221 Compare April 30, 2024 05:20
eseliger
eseliger approved these changes Apr 30, 2024
View reviewed changes
Comment thread internal/gitserver/commands.go Outdated
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 9ce3bb2 to 50df291 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 3e6f221 to ca768ec Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 50df291 to a780150 Compare April 30, 2024 17:14
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from ca768ec to dd16782 Compare April 30, 2024 17:15
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from a780150 to 48d352b Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 4db29a3 to 07e243d Compare May 1, 2024 18:36
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from fa5207c to 1a3843b Compare May 1, 2024 18:36
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from ef5e7e0 to 95e6482 Compare May 1, 2024 18:55
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 1a3843b to c94e22c Compare May 1, 2024 18:55
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 95e6482 to 38ce71d Compare May 1, 2024 19:14
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch 3 times, most recently from 03530b7 to a459014 Compare May 1, 2024 19:26
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 38ce71d to 01c8dae Compare May 1, 2024 19:27
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from a459014 to 666d72e Compare May 1, 2024 19:28
This was referenced May 1, 2024
Merged
Merged
Merged
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 01c8dae to 6b57f46 Compare May 1, 2024 21:12
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 666d72e to 1740b89 Compare May 1, 2024 21:12
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 1740b89 to 15bf6fb Compare May 1, 2024 21:17
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 6b57f46 to 3e9b113 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 15bf6fb to 9ffa2d5 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 3e9b113 to 0102189 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 9ffa2d5 to 34cd911 Compare May 1, 2024 21:25
@ggilmore ggilmore mentioned this pull request May 1, 2024
Merged
@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

TV gif. Ty Burrell as Phil on Modern Family bites his lip as he gives a thumbs up, then points at us as he says, 'Yeah.' (Added via Giphy)

@graphite-app

graphite-app Bot commented May 2, 2024

Copy link
Copy Markdown

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (05/02/24)

1 gif was posted to this PR based on Geoffrey Gilmore's automation.

@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 0102189 to da929c9 Compare May 2, 2024 17:43
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 34cd911 to b56c84d Compare May 2, 2024 17:43
@ggilmore Graphite App

ggilmore commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 3, 1:18 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 1:27 PM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gitserver: Move GetBehindAhead to new gRPC pattern

2 participants

@ggilmore @eseliger