This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: grpc: port GetBehindAhead from client to gitcli backend#62212
Merged
ggilmore merged 4 commits intoMay 2, 2024
Merged
Conversation
This was referenced Apr 26, 2024
Contributor
Author
This was referenced Apr 26, 2024
4c62a2d to
0b1fc2f
Compare
c9d4412 to
e20d95c
Compare
This was referenced Apr 26, 2024
0b1fc2f to
ee4923f
Compare
e20d95c to
5b77abc
Compare
ee4923f to
f8bcb2d
Compare
5b77abc to
a20dd1b
Compare
f8bcb2d to
9e83fa2
Compare
a20dd1b to
85215bf
Compare
85215bf to
ec4200b
Compare
9e83fa2 to
5848e61
Compare
ec4200b to
9cff9f2
Compare
eseliger
approved these changes
Apr 30, 2024
5848e61 to
e3f21ba
Compare
9cff9f2 to
e70c2b0
Compare
e3f21ba to
1cbf637
Compare
e70c2b0 to
2cc3609
Compare
3b2a82d to
b5170ef
Compare
This was referenced May 1, 2024
Merged
b5170ef to
6339643
Compare
ggilmore
commented
May 1, 2024
eseliger
approved these changes
May 1, 2024
Comment on lines
334
to
340
Graphite Automations"Post a GIF when PR approved" took an action on this PR • (05/02/24)1 gif was posted to this PR based on Geoffrey Gilmore's automation. |
3c51a0a to
16b66bb
Compare
16b66bb to
e036062
Compare
ggilmore
added a commit
that referenced
this pull request
May 3, 2024
) Part of https://github.com/sourcegraph/sourcegraph/issues/62101 This PR implements the server-side gRPC implementation of GetBehindAhead, and hooks it up to the new git Backend implementation from #62212. ## Test plan Unit tests
burmudar
pushed a commit
that referenced
this pull request
May 6, 2024
) Part of https://github.com/sourcegraph/sourcegraph/issues/62101 This PR implements the server-side gRPC implementation of GetBehindAhead, and hooks it up to the new git Backend implementation from #62212. ## Test plan Unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Part of https://github.com/sourcegraph/sourcegraph/issues/62101
This PR ports the GetBehindAhead implementation from the gitserver client to the new gitserver.Backend interface.
Here is the original implementation from the client for reference:
Test plan
New unit tests