Closed
Conversation
* WIP queue element * Add verify transaction for queue txs * Add verifyTransaction(..) except witness
* Upgraded to new RingBuffer * First pass at verification function * Removed BaseChain as a contract * Update OVM_CanonicalTransactionChain.spec.ts * Removed unused chain variable * Added overwriting logic to CTC * Corrected CTC event emit * Remove timebound ring buffer tests
* Upgraded to new RingBuffer * First pass at verification function * Removed BaseChain as a contract * Update OVM_CanonicalTransactionChain.spec.ts * Removed unused chain variable * Added overwriting logic to CTC * Corrected CTC event emit * Remove timebound ring buffer tests * Integrated bond manager PR Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
* Require height specification in SCC * Added tests for new functionality * Removed console imports in contracts
* Bump package version * Allow easy emptying of the queue * Simplify appendQueueBatch logic * Fix lint errors * Address feedback
* deployment: script * deploy script: fix error message * scripts: fixes * deploy: update params * deploy: lower inclusion period
* deploy: remove dependency on tsc * deploy: fix typo * deployer: fix typo
* add xdomainmessenger to interface * publish new version
* rebased to master * Fixed resolve in ctc * contracts: remove require statement * Fix broken tests * Fix broken FraudContributor Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com>
* start fixing mocks * fix mock messenger * update version, remove console import
* workinggit status * most up to date * stub safety checker * fix mockOVM_ECDSA, stub safety check * fix nonce ordering, remove failing gas metering config * fix safety checker shift with extra byte of code * remove unused test util * bad semicolon * remove unused vars and import * fix comment * fix mockACCT comment * revert EOA acocunt changes as they are unused in jsvm Co-authored-by: B T <oliphant@Bs-MacBook-Pro.local>
* Started proxy bridge * Fix L1MessengerProxy deploy * Attempt 2 * Fix bug in ResolvedDelegateProxy * Fix bug in L1XDomainMessenger * Reduce nodes in Merkle Trie tests * Fix rebase error * Add clarifying comment to delegate proxy Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
* decompression (not working) * start EIP155 serialization * working decompressor * working CreateEOA, working native EIP155tx * all three tx types working * remove only * fix ECDSAUtil tests * restore original version of smock * add proxys * clean up tests * clean up decompressor tests * clean up ProxyDecompressor * clean up decompressor tests * add CREATEEOA, SETNONCE, GETNONCE tests * working ECDSAContractAccount * fix decompressor * renaming, add deploy * add proxyeoa test, cleanup * remove createEOA type, add extcodesize check * fix decompressor test * support create txs * Decompressor -> Entrypoint * use safeREVERT instead of requires * add isAuthenticated state manager test * update smock * fix sequencerEntrypoint test * add isAuthenticated * Revert "update smock" This reverts commit 286a222414accf9387dcd12ecbed0a66be586bc8. * fix test * Updates to EM * removed kall from contract account * Fixed SSLOAD and SSTORE problems * Fix some broken tests * Fix more bugs & rename to ProxyEOA * WIP fix call test * fix all tests * add gas check * update tests * lint and remove 2000 gas check * Add fees to default EOA (#56) Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com>
* Fix L2XDomainMessenger addr in deploy * xdomain: generalize config, add deploy overrides Co-authored-by: Karl Floersch <karl@karlfloersch.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
Contributor
Author
|
Rebasing on ethereum-optimism/contracts@75e43bb |
e413f47 to
ba4e2c0
Compare
gakonst
suggested changes
Apr 14, 2021
| // This means that the ovmCREATE exception, DOES consumes all nuisance gas allotted, but that allotment | ||
| // is less than the full OVM_TX_GAS_LIMIT / 2 which is alloted to the parent ovmCALL. | ||
| nuisanceGasLeft: 4184829, | ||
| nuisanceGasLeft: 4197042, |
Contributor
There was a problem hiding this comment.
The current master value is the correct one, this should be reverted.
I had changed this here because there was some bug in smock that was fixed here.
@smartcontracts has some context on this, but the post-state nuisance gas checks were wrong because smock was not setting all storage values correctly (the fix to smock addressed that, but resulted in a change in gas costs in the post-state). It was not caught in the old repo because smock was pinned to a specific version (which was the buggy one).
Contributor
Author
There was a problem hiding this comment.
Ah okay, @smartcontracts told me that 4197042 was the correct one.
Contributor
Author
|
Force pushing to |
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* chore(workspace): hoist dependencies to the workspace manifest * test
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation Bump alloy to `0.12` Closes #316 <!-- Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of as being the motivation for your change. --> ## Solution - Bump alloy deps (using patch until 0.12 release) - Bump alloy-core - Impl RlpEcdsaEncodableTx for OpTypedTransaction <!-- Summarize the solution and provide any necessary context needed to understand the code change. --> ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
This PR removes the CLI support for in-memory proof storage (proofs_history_storage_in_mem). The in-memory storage implementation was primarily intended for unit testing and is not feasible for running a node due to the large memory requirements of storing historical trie nodes. Closes #466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives the git history for the
contractspackage based on https://github.com/ben-chain/contracts-v2.Do not merge this pull request. We would need to do a force-push on
masterwith these changes locally to incorporate.