Persistence Updates by willmeister · Pull Request #56 · ethereum-optimism/optimism

willmeister · 2020-03-25T18:18:19Z

Description

Adding and cleaning up configuration via environment variables. Trying to pave the way for persistence in a deployed dev environment.

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

…rs, updating docker compose to pass local environment variables into docker

karlfloersch

This looks good so far but I haven't quite finished the review. Instead I just noticed a bit of terminology that I got confused by and so I'm submitting this as a comment to then send around to make sure it lines up with others intuitions.

Might be good to add stuff like this to a glossary--we've got so many moving parts it's important we're all on the same page with what is what.

karlfloersch · 2020-03-25T18:58:04Z

packages/rollup-full-node/src/app/utils/environment.ts

+ * to consolidate access / updates and default values.
+ */
+export class Environment {
+  // Local Node Config


Looks good! In the spirit of honing my code style intuitions, I have two observations:

These comments are good because they provide context for the organizational structure of the code, not just what the code does.

We could possibly look for a library which handles config but in this case building this class seems like it wouldn't be much harder than using a library, so it's fine to use a "custom" implementation.

karlfloersch · 2020-03-25T19:12:34Z

packages/rollup-full-node/src/app/utils/local-l1-node.ts

+ * @param mnemonic
+ * @param port
+ */
 export const startLocalL1Node = async (


Hmm the terminology here is a little confusing. Am I getting it right that "LocalL1Node" is what we send "InternalTransactions" to? It's just really confusing and I want to make sure we have all of the components mapped out with reasonable terminology.

I just made a diagram which illustrates all of the components.

So to be clear, L1 Node would be just a normal Geth instance that's syncing mainnet Ethereum. Then an L2 Node or maybe more specifically Rollup Node would be the thing that runs an Internal instance of Geth / EVM, which itself either emulates an OVM deployed to it (ExecutionManger, etc).

Does that match up with the terminology being used here?

Yep, that's it! The line in question is to specifically start an L1 node locally to fully exercise the end-to-end functionality of L2 <--> L1 messaging. This is completely different than the L2 Node. I went with L1 and L2 because nothing is actually "rolled up" in the L2 node, and instead, the rollup state sits in the L1 node. Wanted to avoid that confusion. Does L1 and L2 sound good? Happy to rename it to rollup if you think it makes more sense.

Ah great! So I think after staring at this for a while I see where my confusion was. The fact that inside the LocalL1Node we have a sequencerWallet was throwing me off. But it’s just because in this circumstance the L1 that we are running is a Local testnet run by the sequencer.

These L1 & L2 terms are a little confusing! Especially when you see L1ToL2 right next to L2ToL1 — my dyslexia goes crazy! That said, it’s not clear to me that EthNode and RollupNode (for example) are much better 😕 Especially because both are in some sense “Eth” nodes.

I realize this could require some refactoring/renaming (and so I’m happy to not do it) but I wonder if instead of L1ToL2/L2ToL1, we could use the terms L2InboundMessages and L2OutboundMessages or something? Just spitballing and curious what you / @ben-chain think.

It’s a nitpick though & might be specific to my difficulty reading 😂

Oh nvm I take it back. I’m now thinking about l2ToL1MessageReceiver and calling it l2OutboundMessageReceiver and realize that these variable names are going to be confusing basically no matter how we slice it.

Unless y'all absolutely love my naming change (which might have been closer to what Ben did originally?) doesn’t feel worth the switching cost.

…t use geth until we determine private keys / mnemonics and configs

karlfloersch

Alrighty! That took surprisingly long to decipher but happy to say that I understand the code / variable naming now & looks good to me!!! 😄

karlfloersch · 2020-03-26T04:03:54Z

packages/rollup-full-node/src/app/utils/local-l1-node.ts

+ * @param mnemonic
+ * @param port
+ */
 export const startLocalL1Node = async (


Ah great! So I think after staring at this for a while I see where my confusion was. The fact that inside the LocalL1Node we have a sequencerWallet was throwing me off. But it’s just because in this circumstance the L1 that we are running is a Local testnet run by the sequencer.

These L1 & L2 terms are a little confusing! Especially when you see L1ToL2 right next to L2ToL1 — my dyslexia goes crazy! That said, it’s not clear to me that EthNode and RollupNode (for example) are much better 😕 Especially because both are in some sense “Eth” nodes.

I realize this could require some refactoring/renaming (and so I’m happy to not do it) but I wonder if instead of L1ToL2/L2ToL1, we could use the terms L2InboundMessages and L2OutboundMessages or something? Just spitballing and curious what you / @ben-chain think.

It’s a nitpick though & might be specific to my difficulty reading 😂

karlfloersch · 2020-03-26T04:10:35Z

packages/rollup-full-node/src/app/utils/local-l1-node.ts

+ * @param mnemonic
+ * @param port
+ */
 export const startLocalL1Node = async (


Oh nvm I take it back. I’m now thinking about l2ToL1MessageReceiver and calling it l2OutboundMessageReceiver and realize that these variable names are going to be confusing basically no matter how we slice it.

Unless y'all absolutely love my naming change (which might have been closer to what Ben did originally?) doesn’t feel worth the switching cost.

* decompression (not working) * start EIP155 serialization * working decompressor * working CreateEOA, working native EIP155tx * all three tx types working * remove only * fix ECDSAUtil tests * restore original version of smock * add proxys * clean up tests * clean up decompressor tests * clean up ProxyDecompressor * clean up decompressor tests * add CREATEEOA, SETNONCE, GETNONCE tests * working ECDSAContractAccount * fix decompressor * renaming, add deploy * add proxyeoa test, cleanup * remove createEOA type, add extcodesize check * fix decompressor test * support create txs * Decompressor -> Entrypoint * use safeREVERT instead of requires * add isAuthenticated state manager test * update smock * fix sequencerEntrypoint test * add isAuthenticated * Revert "update smock" This reverts commit 286a222414accf9387dcd12ecbed0a66be586bc8. * fix test * Updates to EM * removed kall from contract account * Fixed SSLOAD and SSTORE problems * Fix some broken tests * Fix more bugs & rename to ProxyEOA * WIP fix call test * fix all tests * add gas check * update tests * lint and remove 2000 gas check * Add fees to default EOA (#56) Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Karl Floersch <karl@karlfloersch.com>

…ting-exemptions add more linting exemptions

…imism#56)

Co-authored-by: louis.liu <louis.liu@okg.com>

feat(derive): Span Batch Types

commit 017ba2f Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 23:24:01 2024 +0900 Update package.json commit 4701a20 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 23:23:23 2024 +0900 style: keep code within 100 Columns to improve readability ethereum-optimism#58 - /contracts/stake/managers/SeigManagerV1_3.sol: - /contracts/stake/managers/DepositManagerV1_1.sol: - /contracts/proxy/DAOCommitteeProxy2.sol: commit a97b123 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:55:37 2024 +0900 fix: remove excess empty line ethereum-optimism#58 /contracts/layer2/OperatorManagerProxy.sol remove excess empty line at the end of the contract commit 1bba418 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:54:16 2024 +0900 fix: Delete blank ethereum-optimism#58 /contracts/layer2/Layer2ManagerV1_1.sol: contract Layer2ManagerV1_1 -> contract Layer2ManagerV1_1 commit 9b1d60f Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:51:18 2024 +0900 test: Excluding comparison of Powerton TON balances on the mainnet commit 620d853 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:49:31 2024 +0900 fix: Implementations of the setFactor() function can be put in require statements ethereum-optimism#56

commit 5f9a4c558d7d08519b838223e42f76885cfb3eae Author: Zena-park <zena@tokamak.network> Date: Thu Oct 24 20:40:31 2024 +0900 feat: add LegacySystemConfigProxy ethereum-optimism#57 After implementing the challenge on Titan Candidate, we need to upgrade the logic, so use the proxy. commit aa5494b7a8c00f0008ab9331147d0b5d46528309 Author: Zena-park <zena@tokamak.network> Date: Thu Oct 24 18:02:28 2024 +0900 test commit 8f0cd922e81a577e1526a954f5104456c766e6b1 Author: Zena-park <zena@tokamak.network> Date: Thu Oct 24 13:17:56 2024 +0900 Update 9.check_apy.js commit 19cad49eb5c078e9ab0dd0c5037c7434187f52c6 Author: Zena-park <zena@tokamak.network> Date: Thu Oct 24 13:15:52 2024 +0900 Update 9.check_apy.js commit 177f65cc0283f2823f15ef00da2db9602fd8f8eb Author: Zena-park <zena@tokamak.network> Date: Thu Oct 24 12:52:50 2024 +0900 Create 9.check_apy.js commit d36d5d19e369c700b0b5f1132d9a6313b11eb708 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 23:43:10 2024 +0900 Squashed commit of the following: commit 8f89b1a Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 23:26:26 2024 +0900 Squashed commit of the following: commit 017ba2f Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 23:24:01 2024 +0900 Update package.json commit 4701a20 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 23:23:23 2024 +0900 style: keep code within 100 Columns to improve readability ethereum-optimism#58 - /contracts/stake/managers/SeigManagerV1_3.sol: - /contracts/stake/managers/DepositManagerV1_1.sol: - /contracts/proxy/DAOCommitteeProxy2.sol: commit a97b123 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:55:37 2024 +0900 fix: remove excess empty line ethereum-optimism#58 /contracts/layer2/OperatorManagerProxy.sol remove excess empty line at the end of the contract commit 1bba418 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:54:16 2024 +0900 fix: Delete blank ethereum-optimism#58 /contracts/layer2/Layer2ManagerV1_1.sol: contract Layer2ManagerV1_1 -> contract Layer2ManagerV1_1 commit 9b1d60f Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:51:18 2024 +0900 test: Excluding comparison of Powerton TON balances on the mainnet commit 620d853 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:49:31 2024 +0900 fix: Implementations of the setFactor() function can be put in require statements ethereum-optimism#56 commit 76617fc Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 22:11:34 2024 +0900 test ethereum-optimism#54 commit 795f37c Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:47:01 2024 +0900 Squashed commit of the following: commit e4a7e06135104ee6fe74052f80866324061e7d2e Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:46:34 2024 +0900 chores ethereum-optimism#57 commit afe276cfee706256ede3d6b0167f5c98ac066582 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:46:19 2024 +0900 test: the rehearsal script of sepolia ethereum-optimism#57 commit 632365dc85e19a41d8d2bb5ec8a794c9ba367a52 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:45:10 2024 +0900 feat: initialize the storage ethereum-optimism#57 commit 24f712cc31f85218e27fdc95452a4e1ca6671dd5 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:44:47 2024 +0900 a deployment script ethereum-optimism#57 commit ec5a195b2d427d279abd2400fc34fe332ceeb818 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 17:30:13 2024 +0900 Update 8.dao-staking-v2.5.sepolia.test.ts commit af60315286e9f61b2e6b62b8789b473771a474bb Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 17:28:40 2024 +0900 feat: a deployment script ethereum-optimism#57 commit 9c0e4d8f1ffc58e2e7cd649b07d6a8b0b30d67a5 Merge: 690bc8d 87c1cda Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 17:03:12 2024 +0900 Merge branch 'test-mainnet' into rehearsal-sepolia commit 690bc8d28851612ed23ba0f594b68946c153535b Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 16:42:40 2024 +0900 test commit e4a7e06135104ee6fe74052f80866324061e7d2e Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:46:34 2024 +0900 chores ethereum-optimism#57 commit afe276cfee706256ede3d6b0167f5c98ac066582 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:46:19 2024 +0900 test: the rehearsal script of sepolia ethereum-optimism#57 commit 632365dc85e19a41d8d2bb5ec8a794c9ba367a52 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:45:10 2024 +0900 feat: initialize the storage ethereum-optimism#57 commit 24f712cc31f85218e27fdc95452a4e1ca6671dd5 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 21:44:47 2024 +0900 a deployment script ethereum-optimism#57 commit ec5a195b2d427d279abd2400fc34fe332ceeb818 Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 17:30:13 2024 +0900 Update 8.dao-staking-v2.5.sepolia.test.ts commit af60315286e9f61b2e6b62b8789b473771a474bb Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 17:28:40 2024 +0900 feat: a deployment script ethereum-optimism#57 commit 9c0e4d8f1ffc58e2e7cd649b07d6a8b0b30d67a5 Merge: 690bc8d 87c1cda Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 17:03:12 2024 +0900 Merge branch 'test-mainnet' into rehearsal-sepolia commit 690bc8d28851612ed23ba0f594b68946c153535b Author: Zena-park <zena@tokamak.network> Date: Wed Oct 23 16:42:40 2024 +0900 test

…e statements ethereum-optimism#56

feat(derive): Span Batch Types

* feat(protocol): introduce core protocol types * fix: use alloy primitive types internally for better serialization * fix: tests are only for serde

willmeister added 3 commits March 25, 2020 13:13

Adding L1 node context, adding environment file to consolidate env va…

0d8598b

…rs, updating docker compose to pass local environment variables into docker

updating variable names for clarity

dcba158

updating variable names for clarity

77b6d62

karlfloersch reviewed Mar 25, 2020

View reviewed changes

willmeister added 2 commits March 25, 2020 18:26

Finishing dangling method doc

5711f7d

Adding more logging and error handling. Updating docker-compose to no…

1be0b00

…t use geth until we determine private keys / mnemonics and configs

willmeister merged commit 14fea00 into master Mar 26, 2020

willmeister deleted the persistence_updates branch March 26, 2020 04:09

karlfloersch reviewed Mar 26, 2020

View reviewed changes

protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022

Merge pull request ethereum-optimism#56 from ethereum-optimism/ns/lin…

3af5542

…ting-exemptions add more linting exemptions

gd-0 pushed a commit to gattaca-com/based-optimism that referenced this pull request May 19, 2025

Seal type + marshalling and unmarshalling (ethereum-optimism#56)

e4f6a29

gd-0 pushed a commit to gattaca-com/based-optimism that referenced this pull request May 19, 2025

Seal type + marshalling and unmarshalling (ethereum-optimism#56)

d6e2d0a

blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025

avoid conflict with OptimisticBlockDepositSenderAddress (ethereum-opt…

f8c8218

…imism#56)

cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025

update docker file to use the right image version (ethereum-optimism#56)

b468498

Co-authored-by: louis.liu <louis.liu@okg.com>

theochap pushed a commit that referenced this pull request Dec 10, 2025

Merge pull request #56 from ethereum-optimism/refcell/span-batches

d442891

feat(derive): Span Batch Types

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

fix: Implementations of the setFactor() function can be put in requir…

620d853

…e statements ethereum-optimism#56

theochap pushed a commit that referenced this pull request Jan 14, 2026

Merge pull request #56 from ethereum-optimism/refcell/span-batches

14842dd

feat(derive): Span Batch Types

theochap pushed a commit that referenced this pull request Jan 15, 2026

feat(protocol): Core Protocol Types (#56)

5531b49

* feat(protocol): introduce core protocol types * fix: use alloy primitive types internally for better serialization * fix: tests are only for serde

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Persistence Updates#56

Persistence Updates#56
willmeister merged 5 commits intomasterfrom
persistence_updates

willmeister commented Mar 25, 2020

Uh oh!

karlfloersch left a comment

Uh oh!

karlfloersch Mar 25, 2020

Uh oh!

karlfloersch Mar 25, 2020 •

edited

Loading

Uh oh!

willmeister Mar 25, 2020

Uh oh!

karlfloersch Mar 26, 2020

Uh oh!

karlfloersch Mar 26, 2020

Uh oh!

karlfloersch left a comment

Uh oh!

karlfloersch Mar 26, 2020

Uh oh!

karlfloersch Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

willmeister commented Mar 25, 2020

Description

Contributing Agreement

Uh oh!

karlfloersch left a comment

Choose a reason for hiding this comment

Uh oh!

karlfloersch Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

willmeister Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch left a comment

Choose a reason for hiding this comment

Uh oh!

karlfloersch Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

karlfloersch Mar 25, 2020 •

edited

Loading