Skip to content

Fix bug w/ conversion of nonce to hex#57

Merged
K-Ho merged 1 commit intomasterfrom
Hotfix/FixNonceToHexBug
Mar 26, 2020
Merged

Fix bug w/ conversion of nonce to hex#57
K-Ho merged 1 commit intomasterfrom
Hotfix/FixNonceToHexBug

Conversation

@K-Ho
Copy link
Copy Markdown
Contributor

@K-Ho K-Ho commented Mar 26, 2020

Description

Fixes issue where we were returning 0x10 for getTransactionCount instead of 0xa. The issue was that we were calling .toString(16) on a BigNumber, not a number.

Questions

None

Metadata

None

Contributing Agreement

Copy link
Copy Markdown

@willmeister willmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@K-Ho K-Ho merged commit d2a2962 into master Mar 26, 2020
@K-Ho K-Ho deleted the Hotfix/FixNonceToHexBug branch May 13, 2020 21:20
snario pushed a commit that referenced this pull request Apr 14, 2021
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
* add gnosis safe

* optional transactor and gnosis safe

* add optional rpc support

* update

* update

* update
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
commit e4a7e06135104ee6fe74052f80866324061e7d2e
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:46:34 2024 +0900

    chores ethereum-optimism#57

commit afe276cfee706256ede3d6b0167f5c98ac066582
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:46:19 2024 +0900

    test: the rehearsal script of sepolia ethereum-optimism#57

commit 632365dc85e19a41d8d2bb5ec8a794c9ba367a52
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:45:10 2024 +0900

    feat: initialize the storage ethereum-optimism#57

commit 24f712cc31f85218e27fdc95452a4e1ca6671dd5
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:44:47 2024 +0900

    a deployment script ethereum-optimism#57

commit ec5a195b2d427d279abd2400fc34fe332ceeb818
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 17:30:13 2024 +0900

    Update 8.dao-staking-v2.5.sepolia.test.ts

commit af60315286e9f61b2e6b62b8789b473771a474bb
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 17:28:40 2024 +0900

    feat: a deployment script ethereum-optimism#57

commit 9c0e4d8f1ffc58e2e7cd649b07d6a8b0b30d67a5
Merge: 690bc8d 87c1cda
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 17:03:12 2024 +0900

    Merge branch 'test-mainnet' into rehearsal-sepolia

commit 690bc8d28851612ed23ba0f594b68946c153535b
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 16:42:40 2024 +0900

    test
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
commit 5f9a4c558d7d08519b838223e42f76885cfb3eae
Author: Zena-park <zena@tokamak.network>
Date:   Thu Oct 24 20:40:31 2024 +0900

    feat: add LegacySystemConfigProxy ethereum-optimism#57

    After implementing the challenge on Titan Candidate, we need to upgrade the logic, so use the proxy.

commit aa5494b7a8c00f0008ab9331147d0b5d46528309
Author: Zena-park <zena@tokamak.network>
Date:   Thu Oct 24 18:02:28 2024 +0900

    test

commit 8f0cd922e81a577e1526a954f5104456c766e6b1
Author: Zena-park <zena@tokamak.network>
Date:   Thu Oct 24 13:17:56 2024 +0900

    Update 9.check_apy.js

commit 19cad49eb5c078e9ab0dd0c5037c7434187f52c6
Author: Zena-park <zena@tokamak.network>
Date:   Thu Oct 24 13:15:52 2024 +0900

    Update 9.check_apy.js

commit 177f65cc0283f2823f15ef00da2db9602fd8f8eb
Author: Zena-park <zena@tokamak.network>
Date:   Thu Oct 24 12:52:50 2024 +0900

    Create 9.check_apy.js

commit d36d5d19e369c700b0b5f1132d9a6313b11eb708
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 23:43:10 2024 +0900

    Squashed commit of the following:

    commit 8f89b1a
    Author: Zena-park <zena@tokamak.network>
    Date:   Wed Oct 23 23:26:26 2024 +0900

        Squashed commit of the following:

        commit 017ba2f
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 23:24:01 2024 +0900

            Update package.json

        commit 4701a20
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 23:23:23 2024 +0900

            style: keep code within 100 Columns to improve readability ethereum-optimism#58

            - /contracts/stake/managers/SeigManagerV1_3.sol:
            - /contracts/stake/managers/DepositManagerV1_1.sol:
            - /contracts/proxy/DAOCommitteeProxy2.sol:

        commit a97b123
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 22:55:37 2024 +0900

            fix: remove excess empty line ethereum-optimism#58

            /contracts/layer2/OperatorManagerProxy.sol
            remove excess empty line at the end of the contract

        commit 1bba418
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 22:54:16 2024 +0900

            fix: Delete blank ethereum-optimism#58

            /contracts/layer2/Layer2ManagerV1_1.sol:
            contract  Layer2ManagerV1_1 -> contract Layer2ManagerV1_1

        commit 9b1d60f
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 22:51:18 2024 +0900

            test: Excluding comparison of Powerton TON balances on the mainnet

        commit 620d853
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 22:49:31 2024 +0900

            fix: Implementations of the setFactor() function can be put in require statements ethereum-optimism#56

    commit 76617fc
    Author: Zena-park <zena@tokamak.network>
    Date:   Wed Oct 23 22:11:34 2024 +0900

        test ethereum-optimism#54

    commit 795f37c
    Author: Zena-park <zena@tokamak.network>
    Date:   Wed Oct 23 21:47:01 2024 +0900

        Squashed commit of the following:

        commit e4a7e06135104ee6fe74052f80866324061e7d2e
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 21:46:34 2024 +0900

            chores ethereum-optimism#57

        commit afe276cfee706256ede3d6b0167f5c98ac066582
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 21:46:19 2024 +0900

            test: the rehearsal script of sepolia ethereum-optimism#57

        commit 632365dc85e19a41d8d2bb5ec8a794c9ba367a52
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 21:45:10 2024 +0900

            feat: initialize the storage ethereum-optimism#57

        commit 24f712cc31f85218e27fdc95452a4e1ca6671dd5
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 21:44:47 2024 +0900

            a deployment script ethereum-optimism#57

        commit ec5a195b2d427d279abd2400fc34fe332ceeb818
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 17:30:13 2024 +0900

            Update 8.dao-staking-v2.5.sepolia.test.ts

        commit af60315286e9f61b2e6b62b8789b473771a474bb
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 17:28:40 2024 +0900

            feat: a deployment script ethereum-optimism#57

        commit 9c0e4d8f1ffc58e2e7cd649b07d6a8b0b30d67a5
        Merge: 690bc8d 87c1cda
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 17:03:12 2024 +0900

            Merge branch 'test-mainnet' into rehearsal-sepolia

        commit 690bc8d28851612ed23ba0f594b68946c153535b
        Author: Zena-park <zena@tokamak.network>
        Date:   Wed Oct 23 16:42:40 2024 +0900

            test

commit e4a7e06135104ee6fe74052f80866324061e7d2e
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:46:34 2024 +0900

    chores ethereum-optimism#57

commit afe276cfee706256ede3d6b0167f5c98ac066582
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:46:19 2024 +0900

    test: the rehearsal script of sepolia ethereum-optimism#57

commit 632365dc85e19a41d8d2bb5ec8a794c9ba367a52
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:45:10 2024 +0900

    feat: initialize the storage ethereum-optimism#57

commit 24f712cc31f85218e27fdc95452a4e1ca6671dd5
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 21:44:47 2024 +0900

    a deployment script ethereum-optimism#57

commit ec5a195b2d427d279abd2400fc34fe332ceeb818
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 17:30:13 2024 +0900

    Update 8.dao-staking-v2.5.sepolia.test.ts

commit af60315286e9f61b2e6b62b8789b473771a474bb
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 17:28:40 2024 +0900

    feat: a deployment script ethereum-optimism#57

commit 9c0e4d8f1ffc58e2e7cd649b07d6a8b0b30d67a5
Merge: 690bc8d 87c1cda
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 17:03:12 2024 +0900

    Merge branch 'test-mainnet' into rehearsal-sepolia

commit 690bc8d28851612ed23ba0f594b68946c153535b
Author: Zena-park <zena@tokamak.network>
Date:   Wed Oct 23 16:42:40 2024 +0900

    test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants